foster/deno
0
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-03-03 17:34:47 -05:00
Code Issues Packages 1 Wiki Activity

fix(ext/node): panic in op_node_ecdh_generate_keys (#23011)

Browse source
This commit is contained in:
Divy Srivastava 2024-03-21 12:15:10 +05:30 • committed by GitHub
parent 5a716d1d06
commit 210f2911ce
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 9 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
ext/node/ops/crypto/mod.rs
View file

@ -1048,13 +1048,12 @@ pub async fn op_node_scrypt_async(
} }
#[op2(fast)] #[op2(fast)]
#[smi]
pub fn op_node_ecdh_generate_keys( pub fn op_node_ecdh_generate_keys(
#[string] curve: &str, #[string] curve: &str,
#[buffer] pubbuf: &mut [u8], #[buffer] pubbuf: &mut [u8],
#[buffer] privbuf: &mut [u8], #[buffer] privbuf: &mut [u8],
#[string] format: &str, #[string] format: &str,
) -> Result<ResourceId, AnyError> { ) -> Result<(), AnyError> {
let mut rng = rand::thread_rng(); let mut rng = rand::thread_rng();
let compress = format == "compressed"; let compress = format == "compressed";
match curve { match curve {
@ -1065,30 +1064,33 @@ pub fn op_node_ecdh_generate_keys(
pubbuf.copy_from_slice(pubkey.to_encoded_point(compress).as_ref()); pubbuf.copy_from_slice(pubkey.to_encoded_point(compress).as_ref());
privbuf.copy_from_slice(privkey.to_nonzero_scalar().to_bytes().as_ref()); privbuf.copy_from_slice(privkey.to_nonzero_scalar().to_bytes().as_ref());
Ok(0) Ok(())
} }
"prime256v1" | "secp256r1" => { "prime256v1" | "secp256r1" => {
let privkey = elliptic_curve::SecretKey::<NistP256>::random(&mut rng); let privkey = elliptic_curve::SecretKey::<NistP256>::random(&mut rng);
let pubkey = privkey.public_key(); let pubkey = privkey.public_key();
pubbuf.copy_from_slice(pubkey.to_encoded_point(compress).as_ref()); pubbuf.copy_from_slice(pubkey.to_encoded_point(compress).as_ref());
privbuf.copy_from_slice(privkey.to_nonzero_scalar().to_bytes().as_ref()); privbuf.copy_from_slice(privkey.to_nonzero_scalar().to_bytes().as_ref());
Ok(0)
Ok(())
} }
"secp384r1" => { "secp384r1" => {
let privkey = elliptic_curve::SecretKey::<NistP384>::random(&mut rng); let privkey = elliptic_curve::SecretKey::<NistP384>::random(&mut rng);
let pubkey = privkey.public_key(); let pubkey = privkey.public_key();
pubbuf.copy_from_slice(pubkey.to_encoded_point(compress).as_ref()); pubbuf.copy_from_slice(pubkey.to_encoded_point(compress).as_ref());
privbuf.copy_from_slice(privkey.to_nonzero_scalar().to_bytes().as_ref()); privbuf.copy_from_slice(privkey.to_nonzero_scalar().to_bytes().as_ref());
Ok(0)
Ok(())
} }
"secp224r1" => { "secp224r1" => {
let privkey = elliptic_curve::SecretKey::<NistP224>::random(&mut rng); let privkey = elliptic_curve::SecretKey::<NistP224>::random(&mut rng);
let pubkey = privkey.public_key(); let pubkey = privkey.public_key();
pubbuf.copy_from_slice(pubkey.to_encoded_point(compress).as_ref()); pubbuf.copy_from_slice(pubkey.to_encoded_point(compress).as_ref());
privbuf.copy_from_slice(privkey.to_nonzero_scalar().to_bytes().as_ref()); privbuf.copy_from_slice(privkey.to_nonzero_scalar().to_bytes().as_ref());
Ok(0)
Ok(())
} }
&_ => todo!(), &_ => Err(type_error(format!("Unsupported curve: {}", curve))),
} }
} }