foster/deno
0
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-03-04 01:44:26 -05:00
Code Issues Packages 1 Wiki Activity

perf(test): use core.currentUserCallSite (#20669)

Browse source 
Speeds up `Deno.test` calls by a bit.
This commit is contained in:
Luca Casonato 2023-09-26 10:01:56 +09:00 • committed by GitHub
parent a27ee8f368
commit 26f431fd14
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 25 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
cli/js/40_testing.js
View file

@ -769,22 +769,8 @@ function testInner(
// Delete this prop in case the user passed it. It's used to detect steps. // Delete this prop in case the user passed it. It's used to detect steps.
delete testDesc.parent; delete testDesc.parent;
const jsError = core.destructureError(new Error());
let location;
for (let i = 0; i < jsError.frames.length; i++) { testDesc.location = core.currentUserCallSite();
const filename = jsError.frames[i].fileName;
if (filename.startsWith("ext:") || filename.startsWith("node:")) {
continue;
}
location = {
fileName: jsError.frames[i].fileName,
lineNumber: jsError.frames[i].lineNumber,
columnNumber: jsError.frames[i].columnNumber,
};
break;
}
testDesc.location = location;
testDesc.fn = wrapTest(testDesc); testDesc.fn = wrapTest(testDesc);
testDesc.name = escapeName(testDesc.name); testDesc.name = escapeName(testDesc.name);
@ -1307,12 +1293,7 @@ function createTestContext(desc) {
stepDesc.sanitizeOps ??= desc.sanitizeOps; stepDesc.sanitizeOps ??= desc.sanitizeOps;
stepDesc.sanitizeResources ??= desc.sanitizeResources; stepDesc.sanitizeResources ??= desc.sanitizeResources;
stepDesc.sanitizeExit ??= desc.sanitizeExit; stepDesc.sanitizeExit ??= desc.sanitizeExit;
const jsError = core.destructureError(new Error()); stepDesc.location = core.currentUserCallSite();
stepDesc.location = {
fileName: jsError.frames[1].fileName,
lineNumber: jsError.frames[1].lineNumber,
columnNumber: jsError.frames[1].columnNumber,
};
stepDesc.level = level + 1; stepDesc.level = level + 1;
stepDesc.parent = desc; stepDesc.parent = desc;
stepDesc.rootId = rootId; stepDesc.rootId = rootId;

6
runtime/ops/worker_host.rs
View file

@ -154,10 +154,8 @@ fn op_create_worker(
}; };
let parent_permissions = parent_permissions.clone(); let parent_permissions = parent_permissions.clone();
let worker_id = state.take::<WorkerId>(); let worker_id = state.take::<WorkerId>();
let create_web_worker_cb = state.take::<CreateWebWorkerCbHolder>(); let create_web_worker_cb = state.borrow::<CreateWebWorkerCbHolder>().clone();
state.put::<CreateWebWorkerCbHolder>(create_web_worker_cb.clone()); let format_js_error_fn = state.borrow::<FormatJsErrorFnHolder>().clone();
let format_js_error_fn = state.take::<FormatJsErrorFnHolder>();
state.put::<FormatJsErrorFnHolder>(format_js_error_fn.clone());
state.put::<WorkerId>(worker_id.next().unwrap()); state.put::<WorkerId>(worker_id.next().unwrap());
let module_specifier = deno_core::resolve_url(&specifier)?; let module_specifier = deno_core::resolve_url(&specifier)?;