From 29026fac21d85a530d87ca3e94ae0d547557fa23 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bartek=20Iwa=C5=84czuk?= Date: Mon, 9 Oct 2023 13:23:40 +0200 Subject: [PATCH] chore: disable another flaky Node compat test (#20846) --- .../node_compat/test/internet/test-dns.js | 30 ++++++++++--------- 1 file changed, 16 insertions(+), 14 deletions(-) diff --git a/cli/tests/node_compat/test/internet/test-dns.js b/cli/tests/node_compat/test/internet/test-dns.js index 986bb0d3f3..5cb4fcafdb 100644 --- a/cli/tests/node_compat/test/internet/test-dns.js +++ b/cli/tests/node_compat/test/internet/test-dns.js @@ -214,24 +214,26 @@ TEST(async function test_resolveNs(done) { checkWrap(req); }); -TEST(function test_resolveNs_failure(done) { - dnsPromises.resolveNs(addresses.NOT_FOUND) - .then(common.mustNotCall()) - .catch(common.mustCall((err) => { - assert.strictEqual(err.code, 'ENOTFOUND'); - })); +// TODO(bartlomieju): this test became very flaky on CI, returning `UNKNOWN` +// instead of `ENOTFOUND`. +// TEST(function test_resolveNs_failure(done) { +// dnsPromises.resolveNs(addresses.NOT_FOUND) +// .then(common.mustNotCall()) +// .catch(common.mustCall((err) => { +// assert.strictEqual(err.code, 'ENOTFOUND'); +// })); - const req = dns.resolveNs(addresses.NOT_FOUND, function(err, result) { - assert.ok(err instanceof Error); - assert.strictEqual(err.code, 'ENOTFOUND'); +// const req = dns.resolveNs(addresses.NOT_FOUND, function(err, result) { +// assert.ok(err instanceof Error); +// assert.strictEqual(err.code, 'ENOTFOUND'); - assert.strictEqual(result, undefined); +// assert.strictEqual(result, undefined); - done(); - }); +// done(); +// }); - checkWrap(req); -}); +// checkWrap(req); +// }); TEST(async function test_resolveSrv(done) { function validateResult(result) {