From 308813ae29763512a8be1044b31b8d5dad36c38c Mon Sep 17 00:00:00 2001 From: Yoshiya Hinosawa Date: Tue, 14 Dec 2021 00:35:59 +0900 Subject: [PATCH] fix(ext/web): set location undefined when `--location` is not specified (#13046) --- cli/tests/integration/run_tests.rs | 1 - cli/tests/testdata/071_location_unset.ts.out | 2 +- ext/web/12_location.js | 10 ++-------- 3 files changed, 3 insertions(+), 10 deletions(-) diff --git a/cli/tests/integration/run_tests.rs b/cli/tests/integration/run_tests.rs index dd44824238..b6929b58af 100644 --- a/cli/tests/integration/run_tests.rs +++ b/cli/tests/integration/run_tests.rs @@ -233,7 +233,6 @@ itest!(_070_location { itest!(_071_location_unset { args: "run 071_location_unset.ts", output: "071_location_unset.ts.out", - exit_code: 1, }); itest!(_072_location_relative_fetch { diff --git a/cli/tests/testdata/071_location_unset.ts.out b/cli/tests/testdata/071_location_unset.ts.out index 43308f3bd9..f786d7a64d 100644 --- a/cli/tests/testdata/071_location_unset.ts.out +++ b/cli/tests/testdata/071_location_unset.ts.out @@ -1,4 +1,4 @@ [WILDCARD][Function: Location] Location {} -error: Uncaught ReferenceError: Access to "location", run again with --location . +undefined [WILDCARD] diff --git a/ext/web/12_location.js b/ext/web/12_location.js index 40dd545fe1..36b70b4e60 100644 --- a/ext/web/12_location.js +++ b/ext/web/12_location.js @@ -9,7 +9,6 @@ const { Error, ObjectDefineProperties, - ReferenceError, Symbol, SymbolFor, SymbolToStringTag, @@ -356,8 +355,8 @@ }, }); - let location = null; - let workerLocation = null; + let location = undefined; + let workerLocation = undefined; function setLocationHref(href) { location = new Location(href, locationConstructorKey); @@ -377,11 +376,6 @@ }, locationDescriptor: { get() { - if (location == null) { - throw new ReferenceError( - `Access to "location", run again with --location .`, - ); - } return location; }, set() {