From 4c0b66baab854617993cb242e3be8fe91fb9b0fc Mon Sep 17 00:00:00 2001 From: Asher Gomez Date: Wed, 24 Jan 2024 12:36:51 +1100 Subject: [PATCH] refactor: set removal version for `deno bundle` (#22062) This change sets the removal version for the `deno bundle` sub-command for Deno v2. The warnings appear when `deno bundle` is run and in the `--help` menu. --- cli/args/flags.rs | 5 ++++- cli/tests/testdata/bundle/shebang_file.bundle.out | 4 ++-- cli/tools/bundle.rs | 7 ++----- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/cli/args/flags.rs b/cli/args/flags.rs index 8bb29e72d4..ae63b710c1 100644 --- a/cli/args/flags.rs +++ b/cli/args/flags.rs @@ -1169,7 +1169,10 @@ fn bundle_subcommand() -> Command { Command::new("bundle") .about("Bundle module and dependencies into single file") .long_about( - "Output a single JavaScript file with all dependencies. + "⚠️ Warning: `deno bundle` is deprecated and will be removed in Deno 2.0. +Use an alternative bundler like \"deno_emit\", \"esbuild\" or \"rollup\" instead. + +Output a single JavaScript file with all dependencies. deno bundle https://deno.land/std/http/file_server.ts file_server.bundle.js diff --git a/cli/tests/testdata/bundle/shebang_file.bundle.out b/cli/tests/testdata/bundle/shebang_file.bundle.out index 978fe6d97d..d3369bc9c7 100644 --- a/cli/tests/testdata/bundle/shebang_file.bundle.out +++ b/cli/tests/testdata/bundle/shebang_file.bundle.out @@ -1,5 +1,5 @@ -Warning "deno bundle" is deprecated and will be removed in the future. -Use alternative bundlers like "deno_emit", "esbuild" or "rollup" instead. +⚠️ Warning: `deno bundle` is deprecated and will be removed in Deno 2.0. +Use an alternative bundler like "deno_emit", "esbuild" or "rollup" instead. Bundle file:///[WILDCARD]/subdir/shebang_file.js #!/usr/bin/env -S deno run --allow-read // deno-fmt-ignore-file diff --git a/cli/tools/bundle.rs b/cli/tools/bundle.rs index c703924190..0e54e59f66 100644 --- a/cli/tools/bundle.rs +++ b/cli/tools/bundle.rs @@ -21,11 +21,8 @@ pub async fn bundle( bundle_flags: BundleFlags, ) -> Result<(), AnyError> { log::info!( - "{} \"deno bundle\" is deprecated and will be removed in the future.", - colors::yellow("Warning"), - ); - log::info!( - "Use alternative bundlers like \"deno_emit\", \"esbuild\" or \"rollup\" instead." + "{}", + colors::yellow("⚠️ Warning: `deno bundle` is deprecated and will be removed in Deno 2.0.\nUse an alternative bundler like \"deno_emit\", \"esbuild\" or \"rollup\" instead."), ); if let Some(watch_flags) = &bundle_flags.watch {