diff --git a/cli/tests/unit/command_test.ts b/cli/tests/unit/command_test.ts index 2e73869a91..ce3af08fb2 100644 --- a/cli/tests/unit/command_test.ts +++ b/cli/tests/unit/command_test.ts @@ -885,3 +885,19 @@ Deno.test( ); }, ); + +Deno.test( + "process that fails to spawn, prints its name in error", + async () => { + assertThrows( + () => new Deno.Command("doesntexist").outputSync(), + Error, + "Failed to spawn: doesntexist", + ); + await assertRejects( + async () => await new Deno.Command("doesntexist").output(), + Error, + "Failed to spawn: doesntexist", + ); + }, +); diff --git a/runtime/ops/process.rs b/runtime/ops/process.rs index 14d773af03..076c137657 100644 --- a/runtime/ops/process.rs +++ b/runtime/ops/process.rs @@ -2,6 +2,7 @@ use super::check_unstable; use crate::permissions::PermissionsContainer; +use deno_core::anyhow::Context; use deno_core::error::type_error; use deno_core::error::AnyError; use deno_core::op; @@ -285,7 +286,12 @@ fn spawn_child( // We want to kill child when it's closed command.kill_on_drop(true); - let mut child = command.spawn()?; + let mut child = command.spawn().with_context(|| { + format!( + "Failed to spawn: {}", + command.as_std().get_program().to_string_lossy() + ) + })?; let pid = child.id().expect("Process ID should be set."); let stdin_rid = child @@ -352,8 +358,13 @@ fn op_spawn_sync( ) -> Result { let stdout = matches!(args.stdio.stdout, Stdio::Piped); let stderr = matches!(args.stdio.stderr, Stdio::Piped); - let output = - create_command(state, args, "Deno.Command().outputSync()")?.output()?; + let mut command = create_command(state, args, "Deno.Command().outputSync()")?; + let output = command.output().with_context(|| { + format!( + "Failed to spawn: {}", + command.get_program().to_string_lossy() + ) + })?; Ok(SpawnOutput { status: output.status.try_into()?,