foster/deno
0
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-03-03 17:34:47 -05:00
Code Issues Packages 1 Wiki Activity

fix(ext/node): make nodeGlobalThis configurable (#19163)

Browse source
This commit is contained in:
Luca Casonato 2023-05-17 15:23:18 +03:00 • committed by GitHub
parent 243d9c846d
commit 6a78551635
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
ext/node/lib.rs
View file

@ -490,6 +490,8 @@ pub fn initialize_runtime(
usesLocalNodeModulesDir, usesLocalNodeModulesDir,
argv0 argv0
); );
// Make the nodeGlobalThisName unconfigurable here.
Object.defineProperty(globalThis, nodeGlobalThisName, {{ configurable: false }});
}})('{}', {}, {});"#, }})('{}', {}, {});"#,
NODE_GLOBAL_THIS_NAME, uses_local_node_modules_dir, argv0 NODE_GLOBAL_THIS_NAME, uses_local_node_modules_dir, argv0
); );

2
ext/node/polyfills/02_init.js
View file

@ -40,7 +40,7 @@ function initialize(
// get node's globalThis // get node's globalThis
ObjectDefineProperty(globalThis, nodeGlobalThisName, { ObjectDefineProperty(globalThis, nodeGlobalThisName, {
enumerable: false, enumerable: false,
writable: true, configurable: true,
value: nodeGlobalThis, value: nodeGlobalThis,
}); });
// FIXME(bartlomieju): not nice to depend on `Deno` namespace here // FIXME(bartlomieju): not nice to depend on `Deno` namespace here