From 78c30b1eff877ea5f7315a2b965e3f35693c6bc9 Mon Sep 17 00:00:00 2001 From: David Sherret Date: Tue, 11 Jun 2024 12:47:44 -0400 Subject: [PATCH] ci: error on `chore:` deno_core upgrade pr titles (#24179) --- tools/verify_pr_title.js | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/tools/verify_pr_title.js b/tools/verify_pr_title.js index 3f7f7be03b..9b420ee78f 100644 --- a/tools/verify_pr_title.js +++ b/tools/verify_pr_title.js @@ -7,6 +7,21 @@ if (prTitle == null) { console.log("PR title:", prTitle); +if ( + prTitle.startsWith("chore:") && prTitle.contains("deno_core") && + (prTitle.contains("upgrade") || prTitle.contains("update")) +) { + console.error([ + "Please categorize this deno_core upgrade as a 'feat:', 'fix:' or a ", + "'refactor:'. If your upgrade does not fall into either of these ", + "categories, wait until the next deno_core release.\n\n", + "For feats and fixes, please title your PR outlining the fixed issue ", + "rather than just `fix: upgrade deno_core` so that users understand the ", + "change that was made in the changelog.", + ].join("")); + Deno.exit(1); +} + // This is a release PR, so it's valid. if (/^[^\s]+\.[^\s]+\.[^\s]+$/.test(prTitle)) { console.log("Valid.");