foster/deno
0
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-03-04 01:44:26 -05:00
Code Issues Packages 1 Wiki Activity

Revert "Work around Windows-only V8 concurrent initialization crash"

Browse source 
This fix is no longer necessary as the underlying V8 bug has been
fixed upstream.

This reverts commit 48bcfce09e.
This commit is contained in:
Bert Belder 2019-06-11 23:17:41 +02:00
parent 7fc3d5ed8b
commit 878d092df9
No known key found for this signature in database
GPG key ID: 7A77887B2E2ED461
1 changed files with 1 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
core/libdeno/api.cc
View file

@ -5,10 +5,6 @@
#include <iostream> #include <iostream>
#include <string> #include <string>
// Cpplint bans the use of <mutex> because it duplicates functionality in
// chromium //base. However Deno doensn't use that, so suppress this lint.
#include <mutex> // NOLINT
#include "third_party/v8/include/libplatform/libplatform.h" #include "third_party/v8/include/libplatform/libplatform.h"
#include "third_party/v8/include/v8.h" #include "third_party/v8/include/v8.h"
#include "third_party/v8/src/base/logging.h" #include "third_party/v8/src/base/logging.h"
@ -57,20 +53,7 @@ Deno* deno_new(deno_config config) {
params.snapshot_blob = &d->snapshot_; params.snapshot_blob = &d->snapshot_;
} }
v8::Isolate* isolate; v8::Isolate* isolate = v8::Isolate::New(params);
{
#ifdef _WIN32
// Work around an apparent V8 bug where initializing multiple isolates
// concurrently leads to a crash. At the time of writing the cause of this
// crash is not exactly understood, but it seems to be related to the V8
// internal function win64_unwindinfo::RegisterNonABICompliantCodeRange(),
// which didn't exist in older versions of V8.
static std::mutex mutex;
std::lock_guard<std::mutex> lock(mutex);
#endif
isolate = v8::Isolate::New(params);
}
d->AddIsolate(isolate); d->AddIsolate(isolate);
v8::Locker locker(isolate); v8::Locker locker(isolate);