foster/deno
0
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-03-03 09:31:22 -05:00
Code Issues Packages 1 Wiki Activity

feat(extensions/crypto): implement verify() for HMAC (#11387)

Browse source
This commit is contained in:
Divy Srivastava 2021-08-05 01:19:27 +05:30 • committed by GitHub
parent 2ac031d6fd
commit 87de8e82a1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 16 additions and 33 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
extensions/crypto/00_crypto.js
View file

@ -80,6 +80,7 @@
"verify": {
"RSASSA-PKCS1-v1_5": null,
"RSA-PSS": "RsaPssParams",
"HMAC": null,
},
"importKey": {
"HMAC": "HmacImportParams",
@ -690,6 +691,15 @@
signature,
}, data);
}
case "HMAC": {
const hash = key[_algorithm].hash.name;
return await core.opAsync("op_crypto_verify_key", {
key: keyData,
algorithm: "HMAC",
hash,
signature,
}, data);
}
}
throw new TypeError("unreachable");

5
extensions/crypto/lib.rs
View file

@ -505,6 +505,11 @@ pub async fn op_crypto_verify_key(
.verify(padding, &hashed, &*args.signature)
.is_ok()
}
Algorithm::Hmac => {
let hash: HmacAlgorithm = args.hash.ok_or_else(not_supported)?.into();
let key = HmacKey::new(hash, &*args.key.data);
ring::hmac::verify(&key, data, &*args.signature).is_ok()
}
_ => return Err(type_error("Unsupported algorithm".to_string())),
};

34
tools/wpt/expectation.json
View file

@ -15303,39 +15303,7 @@
"generate wrong key step: HMAC with SHA-1 verifying with wrong algorithm name",
"generate wrong key step: HMAC with SHA-256 verifying with wrong algorithm name",
"generate wrong key step: HMAC with SHA-384 verifying with wrong algorithm name",
"generate wrong key step: HMAC with SHA-512 verifying with wrong algorithm name",
"HMAC with SHA-1 verification",
"HMAC with SHA-256 verification",
"HMAC with SHA-384 verification",
"HMAC with SHA-512 verification",
"HMAC with SHA-1 verification with altered signature after call",
"HMAC with SHA-256 verification with altered signature after call",
"HMAC with SHA-384 verification with altered signature after call",
"HMAC with SHA-512 verification with altered signature after call",
"HMAC with SHA-1 with altered plaintext after call",
"HMAC with SHA-256 with altered plaintext after call",
"HMAC with SHA-384 with altered plaintext after call",
"HMAC with SHA-512 with altered plaintext after call",
"HMAC with SHA-1 no verify usage",
"HMAC with SHA-256 no verify usage",
"HMAC with SHA-384 no verify usage",
"HMAC with SHA-512 no verify usage",
"HMAC with SHA-1 round trip",
"HMAC with SHA-256 round trip",
"HMAC with SHA-384 round trip",
"HMAC with SHA-512 round trip",
"HMAC with SHA-1 verification failure due to wrong plaintext",
"HMAC with SHA-256 verification failure due to wrong plaintext",
"HMAC with SHA-384 verification failure due to wrong plaintext",
"HMAC with SHA-512 verification failure due to wrong plaintext",
"HMAC with SHA-1 verification failure due to wrong signature",
"HMAC with SHA-256 verification failure due to wrong signature",
"HMAC with SHA-384 verification failure due to wrong signature",
"HMAC with SHA-512 verification failure due to wrong signature",
"HMAC with SHA-1 verification failure due to short signature",
"HMAC with SHA-256 verification failure due to short signature",
"HMAC with SHA-384 verification failure due to short signature",
"HMAC with SHA-512 verification failure due to short signature"
"generate wrong key step: HMAC with SHA-512 verifying with wrong algorithm name"
],
"rsa_pkcs.https.any.html": [
"importVectorKeys step: RSASSA-PKCS1-v1_5 with SHA-1 verification",