From 8d1567fafbdac8cd76e736d203eacc578d932a94 Mon Sep 17 00:00:00 2001 From: Ryan Dahl Date: Wed, 13 Feb 2019 14:23:17 -0500 Subject: [PATCH] Upgrade V8 to 7.4.158 (#1767) This is to have access to this fix: https://bugs.chromium.org/p/v8/issues/detail?id=8838 necessary for v8_postmortem_support. --- gclient_config.py | 2 +- libdeno/api.cc | 9 +++++---- third_party | 2 +- 3 files changed, 7 insertions(+), 6 deletions(-) diff --git a/gclient_config.py b/gclient_config.py index 658a4d2fea..331f4e95bb 100644 --- a/gclient_config.py +++ b/gclient_config.py @@ -1,7 +1,7 @@ # Copyright 2018-2019 the Deno authors. All rights reserved. MIT license. solutions = [{ 'url': - 'https://chromium.googlesource.com/v8/v8.git@7.4.98', + 'https://chromium.googlesource.com/v8/v8.git@7.4.158', 'name': 'v8', 'deps_file': 'DEPS', 'custom_deps': { diff --git a/libdeno/api.cc b/libdeno/api.cc index 21ece13a65..2601862a2d 100644 --- a/libdeno/api.cc +++ b/libdeno/api.cc @@ -90,11 +90,12 @@ deno_buf deno_get_snapshot(Deno* d_) { blob.raw_size}; } +static std::unique_ptr platform; + void deno_init() { - // v8::V8::InitializeICUDefaultLocation(argv[0]); - // v8::V8::InitializeExternalStartupData(argv[0]); - auto* p = v8::platform::CreateDefaultPlatform(); - v8::V8::InitializePlatform(p); + CHECK_NULL(platform.get()); + platform = v8::platform::NewDefaultPlatform(); + v8::V8::InitializePlatform(platform.get()); v8::V8::Initialize(); } diff --git a/third_party b/third_party index 6cb1fd4135..c274593346 160000 --- a/third_party +++ b/third_party @@ -1 +1 @@ -Subproject commit 6cb1fd41357d7e26664200f5b891913c14d55365 +Subproject commit c2745933463333cd2f864614d481881f73447cf2