From 9004117790fa23904daffafd347613820bda84ab Mon Sep 17 00:00:00 2001 From: Nayeem Rahman Date: Tue, 19 Sep 2023 13:01:06 +0100 Subject: [PATCH] fix(lsp): refresh npm completions on each character (#20565) --- cli/lsp/completions.rs | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/cli/lsp/completions.rs b/cli/lsp/completions.rs index 7f11daef2f..94111fee81 100644 --- a/cli/lsp/completions.rs +++ b/cli/lsp/completions.rs @@ -167,10 +167,11 @@ pub async fn get_import_completions( items: get_local_completions(specifier, &text, &range)?, })) } else if text.starts_with("npm:") { + let items = + get_npm_completions(specifier, &text, &range, npm_search_api).await?; Some(lsp::CompletionResponse::List(lsp::CompletionList { - is_incomplete: false, - items: get_npm_completions(specifier, &text, &range, npm_search_api) - .await?, + is_incomplete: !items.is_empty(), + items, })) } else if !text.is_empty() { // completion of modules from a module registry or cache