From a8bda560e238181d6c5b01affe328bee4503b9e8 Mon Sep 17 00:00:00 2001 From: Ry Dahl Date: Wed, 22 Jan 2020 12:31:54 -0500 Subject: [PATCH] Change 'cargo publish' test to only do 'cargo package' (#3750) It was found the cargo-package-dry-run test would fail when version numbers are bumped because crates were not actually published. So, for example, deno_typescript 0.30.2 would not be able to find deno_core 0.30.2 because it had not yet been published (see #3744). Ref #3712 --- .github/workflows/ci.yml | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 69075c0545..469837c5d7 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -10,7 +10,7 @@ jobs: strategy: matrix: os: [macOS-latest, windows-2019, ubuntu-16.04] - kind: ['test', 'test_debug', 'bench', 'lint', 'test_publish'] + kind: ['test', 'test_debug', 'bench', 'lint', 'package'] exclude: - os: windows-2019 kind: 'bench' @@ -28,9 +28,9 @@ jobs: kind: 'test_debug' - os: windows-2019 - kind: 'test_publish' + kind: 'package' - os: macOS-latest - kind: 'test_publish' + kind: 'package' steps: - name: Configure git run: git config --global core.symlinks true @@ -132,9 +132,15 @@ jobs: if: matrix.kind == 'test' || matrix.kind == 'bench' run: cargo build --release --locked --all-targets - - name: dry-run cargo package - if: matrix.kind == 'test_publish' - run: ./tools/cargo_publish.py --dry-run + - name: test cargo-package + if: matrix.kind == 'package' + run: | + cd core + cargo package + cd ../deno_typescript + cargo package + cd ../cli + cargo package - name: Test if: matrix.kind == 'test'