0
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-03-04 01:44:26 -05:00

chore: fix flaky tests checking ms when CI is slow (#18559)

This commit is contained in:
David Sherret 2023-04-06 17:48:07 -04:00 committed by Levente Kurusa
parent 05bc5e522d
commit acb9dca497
7 changed files with 33 additions and 31 deletions

View file

@ -5,7 +5,7 @@ test ...
------- output ------- ------- output -------
test test
----- output end ----- ----- output end -----
test ... ok ([WILDCARD]ms) test ... ok ([WILDCARD]s)
ok | 1 passed | 0 failed ([WILDCARD]s) ok | 1 passed | 0 failed ([WILDCARD]s)

View file

@ -1,5 +1,5 @@
running 1 test from ./test/no_prompt_by_default.ts running 1 test from ./test/no_prompt_by_default.ts
no prompt ... FAILED ([WILDCARD]ms) no prompt ... FAILED ([WILDCARD]s)
ERRORS ERRORS
@ -11,6 +11,6 @@ error: PermissionDenied: Requires read access to "./some_file.txt", run again wi
no prompt => ./test/no_prompt_by_default.ts:[WILDCARD] no prompt => ./test/no_prompt_by_default.ts:[WILDCARD]
FAILED | 0 passed | 1 failed ([WILDCARD]ms) FAILED | 0 passed | 1 failed ([WILDCARD]s)
error: Test failed error: Test failed

View file

@ -1,5 +1,5 @@
running 1 test from ./test/no_prompt_with_denied_perms.ts running 1 test from ./test/no_prompt_with_denied_perms.ts
no prompt ... FAILED ([WILDCARD]ms) no prompt ... FAILED ([WILDCARD]s)
ERRORS ERRORS
@ -11,6 +11,6 @@ error: PermissionDenied: Requires read access to "./some_file.txt", run again wi
no prompt => ./test/no_prompt_with_denied_perms.ts:[WILDCARD] no prompt => ./test/no_prompt_with_denied_perms.ts:[WILDCARD]
FAILED | 0 passed | 1 failed ([WILDCARD]ms) FAILED | 0 passed | 1 failed ([WILDCARD]s)
error: Test failed error: Test failed

View file

@ -1,23 +1,23 @@
Check [WILDCARD]/test/parallel_output.ts Check [WILDCARD]/test/parallel_output.ts
./test/parallel_output.ts => step output ... step 1 ... ok ([WILDCARD]ms) ./test/parallel_output.ts => step output ... step 1 ... ok ([WILDCARD]s)
./test/parallel_output.ts => step output ... step 2 ... ok ([WILDCARD]ms) ./test/parallel_output.ts => step output ... step 2 ... ok ([WILDCARD]s)
------- output ------- ------- output -------
Hello, world! (from step 3) Hello, world! (from step 3)
----- output end ----- ----- output end -----
./test/parallel_output.ts => step output ... step 3 ... ok ([WILDCARD]ms) ./test/parallel_output.ts => step output ... step 3 ... ok ([WILDCARD]s)
------- output ------- ------- output -------
Hello, world! (from step 4) Hello, world! (from step 4)
----- output end ----- ----- output end -----
./test/parallel_output.ts => step output ... step 4 ... ok ([WILDCARD]ms) ./test/parallel_output.ts => step output ... step 4 ... ok ([WILDCARD]s)
./test/parallel_output.ts => step output ... ok ([WILDCARD]ms) ./test/parallel_output.ts => step output ... ok ([WILDCARD]s)
./test/parallel_output.ts => step failures ... step 1 ... ok ([WILDCARD]ms) ./test/parallel_output.ts => step failures ... step 1 ... ok ([WILDCARD]s)
./test/parallel_output.ts => step failures ... step 2 ... FAILED ([WILDCARD]ms) ./test/parallel_output.ts => step failures ... step 2 ... FAILED ([WILDCARD]s)
./test/parallel_output.ts => step failures ... step 3 ... FAILED ([WILDCARD]ms) ./test/parallel_output.ts => step failures ... step 3 ... FAILED ([WILDCARD]s)
./test/parallel_output.ts => step failures ... FAILED (due to 2 failed steps) ([WILDCARD]ms) ./test/parallel_output.ts => step failures ... FAILED (due to 2 failed steps) ([WILDCARD]s)
./test/parallel_output.ts => step nested failure ... step 1 ... inner 1 ... ok ([WILDCARD]ms) ./test/parallel_output.ts => step nested failure ... step 1 ... inner 1 ... ok ([WILDCARD]s)
./test/parallel_output.ts => step nested failure ... step 1 ... inner 2 ... FAILED ([WILDCARD]ms) ./test/parallel_output.ts => step nested failure ... step 1 ... inner 2 ... FAILED ([WILDCARD]s)
./test/parallel_output.ts => step nested failure ... step 1 ... FAILED (due to 1 failed step) ([WILDCARD]ms) ./test/parallel_output.ts => step nested failure ... step 1 ... FAILED (due to 1 failed step) ([WILDCARD]s)
./test/parallel_output.ts => step nested failure ... FAILED (due to 1 failed step) ([WILDCARD]ms) ./test/parallel_output.ts => step nested failure ... FAILED (due to 1 failed step) ([WILDCARD]s)
ERRORS ERRORS
@ -51,6 +51,6 @@ step failures ... step 2 => ./test/parallel_output.ts:14:11
step failures ... step 3 => ./test/parallel_output.ts:17:11 step failures ... step 3 => ./test/parallel_output.ts:17:11
step nested failure ... step 1 ... inner 2 => ./test/parallel_output.ts:23:13 step nested failure ... step 1 ... inner 2 => ./test/parallel_output.ts:23:13
FAILED | 1 passed (6 steps) | 2 failed (4 steps) ([WILDCARD]ms) FAILED | 1 passed (6 steps) | 2 failed (4 steps) ([WILDCARD]s)
error: Test failed error: Test failed

View file

@ -12,18 +12,18 @@ description ...
------- output ------- ------- output -------
3 3
----- output end ----- ----- output end -----
inner 1 ... ok ([WILDCARD]ms) inner 1 ... ok ([WILDCARD]s)
inner 2 ... inner 2 ...
------- output ------- ------- output -------
4 4
----- output end ----- ----- output end -----
inner 2 ... ok ([WILDCARD]ms) inner 2 ... ok ([WILDCARD]s)
------- output ------- ------- output -------
5 5
----- output end ----- ----- output end -----
step 1 ... ok ([WILDCARD]ms) step 1 ... ok ([WILDCARD]s)
------- output ------- ------- output -------
6 6
----- output end ----- ----- output end -----
description ... ok ([WILDCARD]ms) description ... ok ([WILDCARD]s)
[WILDCARD] [WILDCARD]

View file

@ -2,16 +2,16 @@
running 6 tests from ./test/steps/passing_steps.ts running 6 tests from ./test/steps/passing_steps.ts
description ... description ...
step 1 ... step 1 ...
inner 1 ... ok ([WILDCARD]ms) inner 1 ... ok ([WILDCARD]s)
inner 2 ... ok ([WILDCARD]ms) inner 2 ... ok ([WILDCARD]s)
step 1 ... ok ([WILDCARD]ms) step 1 ... ok ([WILDCARD]s)
description ... ok ([WILDCARD]ms) description ... ok ([WILDCARD]s)
description function as first arg ... description function as first arg ...
step1 ... step1 ...
inner1 ... ok ([WILDCARD]ms) inner1 ... ok ([WILDCARD]s)
inner1 ... ok ([WILDCARD]ms) inner1 ... ok ([WILDCARD]s)
step1 ... ok ([WILDCARD]ms) step1 ... ok ([WILDCARD]s)
description function as first arg ... ok ([WILDCARD]ms) description function as first arg ... ok ([WILDCARD]s)
parallel steps without sanitizers ... parallel steps without sanitizers ...
step 1 ... ok ([WILDCARD]) step 1 ... ok ([WILDCARD])
step 2 ... ok ([WILDCARD]) step 2 ... ok ([WILDCARD])

View file

@ -650,6 +650,7 @@ impl PrettyTestReporter {
failures_by_origin.entry(origin.clone()).or_default(); failures_by_origin.entry(origin.clone()).or_default();
let _ = uncaught_error.insert(js_error.as_ref()); let _ = uncaught_error.insert(js_error.as_ref());
} }
// note: the trailing whitespace is intentional to get a red background
println!("\n{}\n", colors::white_bold_on_red(" ERRORS ")); println!("\n{}\n", colors::white_bold_on_red(" ERRORS "));
for (origin, (failures, uncaught_error)) in failures_by_origin { for (origin, (failures, uncaught_error)) in failures_by_origin {
for (description, failure) in failures { for (description, failure) in failures {
@ -678,6 +679,7 @@ impl PrettyTestReporter {
failure_titles.push(failure_title); failure_titles.push(failure_title);
} }
} }
// note: the trailing whitespace is intentional to get a red background
println!("{}\n", colors::white_bold_on_red(" FAILURES ")); println!("{}\n", colors::white_bold_on_red(" FAILURES "));
for failure_title in failure_titles { for failure_title in failure_titles {
println!("{failure_title}"); println!("{failure_title}");