From bd6938ac7070bbfb367f0a41b20a18bfa27e8ee8 Mon Sep 17 00:00:00 2001
From: Divy Srivastava <dj.srivastava23@gmail.com>
Date: Mon, 18 Mar 2024 13:48:55 +0530
Subject: [PATCH] fix(node): implement v8 serialize and deserialize (#22975)

Fixes https://github.com/denoland/deno/issues/22971
---
 ext/node/polyfills/v8.ts   | 13 +++++++++----
 tests/unit_node/v8_test.ts | 11 +++++++++++
 2 files changed, 20 insertions(+), 4 deletions(-)

diff --git a/ext/node/polyfills/v8.ts b/ext/node/polyfills/v8.ts
index a1ea16430f..cad00bd7f7 100644
--- a/ext/node/polyfills/v8.ts
+++ b/ext/node/polyfills/v8.ts
@@ -1,14 +1,19 @@
 // Copyright 2018-2024 the Deno authors. All rights reserved. MIT license.
 // Copyright Joyent and Node contributors. All rights reserved. MIT license.
 
+/// <reference path="../../core/internal.d.ts" />
+
 // TODO(petamoriken): enable prefer-primordials for node polyfills
 // deno-lint-ignore-file prefer-primordials
 
+import { core } from "ext:core/mod.js";
 import {
   op_v8_cached_data_version_tag,
   op_v8_get_heap_statistics,
 } from "ext:core/ops";
 
+import { Buffer } from "node:buffer";
+
 import { notImplemented } from "ext:deno_node/_utils.ts";
 
 export function cachedDataVersionTag() {
@@ -66,11 +71,11 @@ export function takeCoverage() {
 export function writeHeapSnapshot() {
   notImplemented("v8.writeHeapSnapshot");
 }
-export function serialize() {
-  notImplemented("v8.serialize");
+export function serialize(value) {
+  return Buffer.from(core.serialize(value));
 }
-export function deserialize() {
-  notImplemented("v8.deserialize");
+export function deserialize(data) {
+  return core.deserialize(data);
 }
 export class Serializer {
   constructor() {
diff --git a/tests/unit_node/v8_test.ts b/tests/unit_node/v8_test.ts
index c9697c8700..b91d595dbc 100644
--- a/tests/unit_node/v8_test.ts
+++ b/tests/unit_node/v8_test.ts
@@ -1,7 +1,9 @@
 // Copyright 2018-2024 the Deno authors. All rights reserved. MIT license.
 import {
   cachedDataVersionTag,
+  deserialize,
   getHeapStatistics,
+  serialize,
   setFlagsFromString,
 } from "node:v8";
 import { assertEquals } from "@std/assert/mod.ts";
@@ -53,3 +55,12 @@ Deno.test({
     setFlagsFromString("--allow_natives_syntax");
   },
 });
+
+Deno.test({
+  name: "serialize deserialize",
+  fn() {
+    const s = serialize({ a: 1 });
+    const d = deserialize(s);
+    assertEquals(d, { a: 1 });
+  },
+});