foster/deno
0
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-03-03 17:34:47 -05:00
Code Issues Packages 1 Wiki Activity

fix(op_crates/web) make isTrusted not constructable (#8337)

Browse source
This commit is contained in:
Benjamin Gruenbaum 2020-11-10 22:26:58 +02:00 • committed by GitHub
parent b255a05f18
commit c7804c06ad
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 16 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
op_crates/web/01_event.js
View file

@ -98,9 +98,11 @@
return "relatedTarget" in event; return "relatedTarget" in event;
} }
function isTrusted() { const isTrusted = Object.getOwnPropertyDescriptor({
return eventData.get(this).isTrusted; get isTrusted() {
} return eventData.get(this).isTrusted;
},
}, "isTrusted").get;
class Event { class Event {
#canceledFlag = false; #canceledFlag = false;

11
op_crates/web/event_test.js
View file

@ -96,6 +96,16 @@ function eventIsTrusted() {
assert(desc1.get === desc2.get); assert(desc1.get === desc2.get);
} }
function eventIsTrustedGetterName() {
const { get } = Object.getOwnPropertyDescriptor(new Event("x"), "isTrusted");
assert(get.name === "get isTrusted");
try {
Reflect.construct(get);
throw new Error("Should not have reached here");
} catch (e) {
assert(e.message.includes("not a constructor"));
}
}
function main() { function main() {
eventInitializedWithType(); eventInitializedWithType();
eventInitializedWithTypeAndDict(); eventInitializedWithTypeAndDict();
@ -105,6 +115,7 @@ function main() {
eventPreventDefaultSuccess(); eventPreventDefaultSuccess();
eventInitializedWithNonStringType(); eventInitializedWithNonStringType();
eventIsTrusted(); eventIsTrusted();
eventIsTrustedGetterName();
} }
main(); main();