fix(repl): prevent symbol completion panic (#9400)

cli/tests/integration_tests.rs

@@ -1751,6 +1751,31 @@ mod integration {
       }
     }
 
+    #[cfg(unix)]
+    #[test]
+    fn pty_complete_symbol() {
+      use std::io::Read;
+      use util::pty::fork::*;
+      let deno_exe = util::deno_exe_path();
+      let fork = Fork::from_ptmx().unwrap();
+      if let Ok(mut master) = fork.is_parent() {
+        master.write_all(b"Deno.internal\t\n").unwrap();
+        master.write_all(b"close();\n").unwrap();
+
+        let mut output = String::new();
+        master.read_to_string(&mut output).unwrap();
+
+        assert!(output.contains("Symbol(Deno.internal)"));
+
+        fork.wait().unwrap();
+      } else {
+        std::env::set_var("NO_COLOR", "1");
+        let err = exec::Command::new(deno_exe).arg("repl").exec();
+        println!("err {}", err);
+        unreachable!()
+      }
+    }
+
     #[test]
     fn console_log() {
       let (out, err) = util::run_and_collect_output(

cli/tools/repl.rs

@@ -103,25 +103,25 @@ impl Completer for Helper {
 
     if let Some(result) = evaluate_response.get("result") {
       if let Some(object_id) = result.get("objectId") {
-        let get_properties_response = self
+        let get_properties_response = self.post_message(
-          .post_message(
+          "Runtime.getProperties",
-            "Runtime.getProperties",
+          Some(json!({
-            Some(json!({
+            "objectId": object_id,
-              "objectId": object_id,
+          })),
-            })),
+        );
-          )
-          .unwrap();
 
-        if let Some(result) = get_properties_response.get("result") {
+        if let Ok(get_properties_response) = get_properties_response {
-          let candidates = result
+          if let Some(result) = get_properties_response.get("result") {
-            .as_array()
+            let candidates = result
-            .unwrap()
+              .as_array()
-            .iter()
+              .unwrap()
-            .map(|r| r.get("name").unwrap().as_str().unwrap().to_string())
+              .iter()
-            .filter(|r| r.starts_with(&suffix[1..]))
+              .map(|r| r.get("name").unwrap().as_str().unwrap().to_string())
-            .collect();
+              .filter(|r| r.starts_with(&suffix[1..]))
+              .collect();
 
-          return Ok((pos - (suffix.len() - 1), candidates));
+            return Ok((pos - (suffix.len() - 1), candidates));
+          }
         }
       }
     }