foster/deno
0
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-03-03 17:34:47 -05:00
Code Issues Packages 1 Wiki Activity

formData: set default filename for Blob to <blob> (#5907)

Browse source
This commit is contained in:
Marcos Casagrande 2020-05-28 15:02:00 +02:00 • committed by GitHub
parent 3cbcdd4250
commit c9bbb200d6
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 30 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
cli/js/web/form_data.ts
View file

@ -22,7 +22,7 @@ class FormDataBase {
if (value instanceof domFile.DomFileImpl) { if (value instanceof domFile.DomFileImpl) {
this[dataSymbol].push([name, value]); this[dataSymbol].push([name, value]);
} else if (value instanceof blob.DenoBlob) { } else if (value instanceof blob.DenoBlob) {
const dfile = new domFile.DomFileImpl([value], filename || name, { const dfile = new domFile.DomFileImpl([value], filename || "blob", {
type: value.type, type: value.type,
}); });
this[dataSymbol].push([name, dfile]); this[dataSymbol].push([name, dfile]);
@ -96,7 +96,7 @@ class FormDataBase {
if (value instanceof domFile.DomFileImpl) { if (value instanceof domFile.DomFileImpl) {
this[dataSymbol][i][1] = value; this[dataSymbol][i][1] = value;
} else if (value instanceof blob.DenoBlob) { } else if (value instanceof blob.DenoBlob) {
const dfile = new domFile.DomFileImpl([value], filename || name, { const dfile = new domFile.DomFileImpl([value], filename || "blob", {
type: value.type, type: value.type,
}); });
this[dataSymbol][i][1] = dfile; this[dataSymbol][i][1] = dfile;
@ -117,7 +117,7 @@ class FormDataBase {
if (value instanceof domFile.DomFileImpl) { if (value instanceof domFile.DomFileImpl) {
this[dataSymbol].push([name, value]); this[dataSymbol].push([name, value]);
} else if (value instanceof blob.DenoBlob) { } else if (value instanceof blob.DenoBlob) {
const dfile = new domFile.DomFileImpl([value], filename || name, { const dfile = new domFile.DomFileImpl([value], filename || "blob", {
type: value.type, type: value.type,
}); });
this[dataSymbol].push([name, dfile]); this[dataSymbol].push([name, dfile]);

18
cli/tests/unit/fetch_test.ts
View file

@ -359,6 +359,24 @@ unitTest(
} }
); );
unitTest(
{ perms: { net: true } },
async function fetchInitFormDataBlobFilenameBody(): Promise<void> {
const form = new FormData();
form.append("field", "value");
form.append("file", new Blob([new TextEncoder().encode("deno")]));
const response = await fetch("http://localhost:4545/echo_server", {
method: "POST",
body: form,
});
const resultForm = await response.formData();
assertEquals(form.get("field"), resultForm.get("field"));
const file = resultForm.get("file");
assert(file instanceof File);
assertEquals(file.name, "blob");
}
);
unitTest({ perms: { net: true } }, async function fetchUserAgent(): Promise< unitTest({ perms: { net: true } }, async function fetchUserAgent(): Promise<
void void
> { > {

9
cli/tests/unit/form_data_test.ts
View file

@ -99,6 +99,15 @@ unitTest(function formDataSetEmptyBlobSuccess(): void {
*/ */
}); });
unitTest(function formDataBlobFilename(): void {
const formData = new FormData();
const content = new TextEncoder().encode("deno");
formData.set("a", new Blob([content]));
const file = formData.get("a");
assert(file instanceof File);
assertEquals(file.name, "blob");
});
unitTest(function formDataParamsForEachSuccess(): void { unitTest(function formDataParamsForEachSuccess(): void {
const init = [ const init = [
["a", "54"], ["a", "54"],