From d226970c0ed1e5a9691b7f22a91792b3e6955d9c Mon Sep 17 00:00:00 2001 From: Matt Mastracci Date: Fri, 15 Sep 2023 08:53:38 -0600 Subject: [PATCH] chore(ext/http): fix a rejection test (#20514) Use `assertRejects` to actually catch errors. --- cli/tests/unit/serve_test.ts | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/cli/tests/unit/serve_test.ts b/cli/tests/unit/serve_test.ts index 76433f1e3f..cfe74e6594 100644 --- a/cli/tests/unit/serve_test.ts +++ b/cli/tests/unit/serve_test.ts @@ -967,12 +967,9 @@ function createStreamTest(count: number, delay: number, action: string) { await listeningPromise; const resp = await fetch(`http://127.0.0.1:${servePort}/`); if (action == "Throw") { - try { + await assertRejects(async () => { await resp.text(); - fail(); - } catch (_) { - // expected - } + }); } else { const text = await resp.text(); @@ -985,7 +982,7 @@ function createStreamTest(count: number, delay: number, action: string) { } } finally { ac.abort(); - await server.finished; + await server.shutdown(); } }); }