From da9219341fe8bcf080d3ebdd03d35cec1268875e Mon Sep 17 00:00:00 2001 From: Casper Beyer Date: Mon, 12 Apr 2021 19:33:05 +0800 Subject: [PATCH] feat(runtime): add stat and statSync methods to Deno.File (#10107) --- cli/dts/lib.deno.ns.d.ts | 2 ++ cli/tests/unit/file_test.ts | 32 +++++++++++++++++++++++++ runtime/js/30_fs.js | 4 ++-- runtime/js/{30_files.js => 40_files.js} | 9 +++++++ 4 files changed, 45 insertions(+), 2 deletions(-) rename runtime/js/{30_files.js => 40_files.js} (95%) diff --git a/cli/dts/lib.deno.ns.d.ts b/cli/dts/lib.deno.ns.d.ts index 7d248e4b28..a4ef6bc68c 100644 --- a/cli/dts/lib.deno.ns.d.ts +++ b/cli/dts/lib.deno.ns.d.ts @@ -785,6 +785,8 @@ declare namespace Deno { readSync(p: Uint8Array): number | null; seek(offset: number, whence: SeekMode): Promise; seekSync(offset: number, whence: SeekMode): number; + stat(): Promise; + statSync(): FileInfo; close(): void; } diff --git a/cli/tests/unit/file_test.ts b/cli/tests/unit/file_test.ts index eaafbae274..6401980347 100644 --- a/cli/tests/unit/file_test.ts +++ b/cli/tests/unit/file_test.ts @@ -103,3 +103,35 @@ unitTest(function fileUsingNumberFileName(): void { unitTest(function fileUsingEmptyStringFileName(): void { testSecondArgument("", ""); }); + +unitTest({ perms: { read: true } }, function fileStatSyncSuccess(): void { + const file = Deno.openSync("README.md"); + const fileInfo = file.statSync(); + assert(fileInfo.isFile); + assert(!fileInfo.isSymlink); + assert(!fileInfo.isDirectory); + assert(fileInfo.size); + assert(fileInfo.atime); + assert(fileInfo.mtime); + // The `birthtime` field is not available on Linux before kernel version 4.11. + assert(fileInfo.birthtime || Deno.build.os === "linux"); + + file.close(); +}); + +unitTest({ perms: { read: true } }, async function fileStatSuccess(): Promise< + void +> { + const file = await Deno.open("README.md"); + const fileInfo = await file.stat(); + assert(fileInfo.isFile); + assert(!fileInfo.isSymlink); + assert(!fileInfo.isDirectory); + assert(fileInfo.size); + assert(fileInfo.atime); + assert(fileInfo.mtime); + // The `birthtime` field is not available on Linux before kernel version 4.11. + assert(fileInfo.birthtime || Deno.build.os === "linux"); + + file.close(); +}); diff --git a/runtime/js/30_fs.js b/runtime/js/30_fs.js index e792476408..af2aebd3ec 100644 --- a/runtime/js/30_fs.js +++ b/runtime/js/30_fs.js @@ -390,8 +390,6 @@ removeSync, renameSync, rename, - fstatSync, - fstat, lstat, lstatSync, stat, @@ -403,6 +401,8 @@ umask, link, linkSync, + fstatSync, + fstat, futime, futimeSync, utime, diff --git a/runtime/js/30_files.js b/runtime/js/40_files.js similarity index 95% rename from runtime/js/30_files.js rename to runtime/js/40_files.js index f9898c5d87..2ce495f8e4 100644 --- a/runtime/js/30_files.js +++ b/runtime/js/40_files.js @@ -4,6 +4,7 @@ ((window) => { const core = window.Deno.core; const { read, readSync, write, writeSync } = window.__bootstrap.io; + const { fstat, fstatSync } = window.__bootstrap.fs; const { pathFromURL } = window.__bootstrap.util; function seekSync( @@ -103,6 +104,14 @@ return seekSync(this.rid, offset, whence); } + stat() { + return fstat(this.rid); + } + + statSync() { + return fstatSync(this.rid); + } + close() { core.close(this.rid); }