From e63c53315450ed305752566f4c3ad2bb76c8b8a3 Mon Sep 17 00:00:00 2001
From: Ryan Dahl <ry@tinyclouds.org>
Date: Wed, 28 Apr 2021 15:10:44 -0400
Subject: [PATCH] enable error-on-warning (#10410)

Only on linux and osx. Fixes one warning.
---
 .github/workflows/ci.yml | 8 ++++++--
 core/runtime.rs          | 2 +-
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 2d433d0305..ab2183de76 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -48,8 +48,6 @@ jobs:
     env:
       RUST_BACKTRACE: full
       CARGO_TERM_COLOR: always
-      # TODO(ry) Enable error on warning after fixing https://github.com/denoland/deno/issues/10378
-      # RUSTFLAGS: -D warnings
 
     steps:
       - name: Configure git
@@ -93,6 +91,12 @@ jobs:
           curl -fsSL https://deno.land/x/install/install.sh | sh -s v1.7.2
           echo "$HOME/.deno/bin" >> $GITHUB_PATH
 
+      # TODO(ry) Enable on all OSes https://github.com/denoland/deno/issues/10378
+      - name: Error on Warning
+        if: |
+          !startsWith(matrix.os, 'windows')
+        run: echo "RUSTFLAGS=-D warnings" >> $GITHUB_ENV
+
       - name: Install Deno (Windows)
         if: startsWith(matrix.os, 'windows')
         run: |-
diff --git a/core/runtime.rs b/core/runtime.rs
index 51b231eb0c..4cfcad0ba4 100644
--- a/core/runtime.rs
+++ b/core/runtime.rs
@@ -403,7 +403,7 @@ impl JsRuntime {
     for e in extensions.iter_mut() {
       e.init_state(&mut op_state.borrow_mut())?;
       // Register each op after middlewaring it
-      let mut ops = e.init_ops().unwrap_or_default();
+      let ops = e.init_ops().unwrap_or_default();
       for (name, opfn) in ops {
         self.register_op(name, macroware(name, opfn));
       }