From f2d5e6f58ac6e1f58091edf74053aaa695a26b8e Mon Sep 17 00:00:00 2001 From: Ryan Dahl Date: Mon, 27 Apr 2020 18:00:19 -0400 Subject: [PATCH] loadavg and osRelease made unstable (#4938) --- cli/js/lib.deno.ns.d.ts | 6 ++++++ cli/ops/os.rs | 2 ++ 2 files changed, 8 insertions(+) diff --git a/cli/js/lib.deno.ns.d.ts b/cli/js/lib.deno.ns.d.ts index ffa560a73f..1834794a80 100644 --- a/cli/js/lib.deno.ns.d.ts +++ b/cli/js/lib.deno.ns.d.ts @@ -97,6 +97,9 @@ declare namespace Deno { * console.log(Deno.loadavg()); // e.g. [ 0.71, 0.44, 0.44 ] * * Requires `allow-env` permission. + * + * **Unstable** There are questions around which permission this needs. And + * maybe should be renamed (loadAverage?) */ export function loadavg(): number[]; @@ -113,6 +116,9 @@ declare namespace Deno { * console.log(Deno.osRelease()); * * Requires `allow-env` permission. + * + * **Unstable** new API maybe move to Deno.build or Deno.versions? Depends on + * sys-info, which we don't necessarally want to depend on. */ export function osRelease(): string; diff --git a/cli/ops/os.rs b/cli/ops/os.rs index 43e45b3fe7..5c205f37b6 100644 --- a/cli/ops/os.rs +++ b/cli/ops/os.rs @@ -156,6 +156,7 @@ fn op_loadavg( _args: Value, _zero_copy: Option, ) -> Result { + state.check_unstable("Deno.loadavg"); state.check_env()?; match sys_info::loadavg() { Ok(loadavg) => Ok(JsonOp::Sync(json!([ @@ -182,6 +183,7 @@ fn op_os_release( _args: Value, _zero_copy: Option, ) -> Result { + state.check_unstable("Deno.osRelease"); state.check_env()?; let release = sys_info::os_release().unwrap_or_else(|_| "".to_string()); Ok(JsonOp::Sync(json!(release)))