0
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-03-03 09:31:22 -05:00

fix(node): resolve .css files in npm packages when type checking (#22804)

When type checking, we should just resolve css files in npm packages and
not surface a type checking error on the specifier.
This commit is contained in:
David Sherret 2024-03-08 14:14:28 -05:00 committed by GitHub
parent 8fdc376b4a
commit fee4943f76
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 30 additions and 0 deletions

View file

@ -518,6 +518,10 @@ impl NodeResolver {
return Some(path);
}
}
// allow resolving .css files for types resolution
if lowercase_path.ends_with(".css") {
return Some(path);
}
None
}

View file

@ -2551,6 +2551,22 @@ console.log(getValue());
output.assert_matches_text("Check file:///[WILDCARD]/main.ts\n");
}
#[test]
fn check_css_package_json_exports() {
let test_context = TestContextBuilder::for_npm().use_temp_cwd().build();
let dir = test_context.temp_dir();
dir.write(
"main.ts",
r#"import "npm:@denotest/css-export/dist/index.css";"#,
);
test_context
.new_command()
.args("check main.ts")
.run()
.assert_matches_text("Download [WILDCARD]css-export\nDownload [WILDCARD]css-export/1.0.0.tgz\nCheck [WILDCARD]/main.ts\n")
.assert_exit_code(0);
}
#[test]
fn cjs_export_analysis_require_re_export() {
let test_context = TestContextBuilder::for_npm().use_temp_cwd().build();

View file

@ -0,0 +1 @@
body {}

View file

@ -0,0 +1,9 @@
{
"name": "@denotest/css-export",
"version": "1.0.0",
"type": "module",
"exports": {
".": "./index.js",
"./dist/*": "./dist/*"
}
}