0
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-03-03 17:34:47 -05:00
deno/runtime
Andreu Botella b7c2902c97
Don't drop messages from workers that have already been closed (#11913)
When `worker.terminate()` is called, the spec requires that the
corresponding port message queue is emptied, so no messages can be
received after the call, even if they were sent from the worker before
it was terminated.

The spec doesn't require this of `self.close()`, and since Deno uses
different channels to send messages and to notify that the worker was
closed, messages might still arrive after the worker is known to be
closed, which are currently being dropped. This change fixes that.

The fix involves two parts: one on the JS side and one on the Rust side.
The JS side was using the `#terminated` flag to keep track of whether
the worker is known to be closed, without distinguishing whether further
messages should be dropped or not. This PR changes that flag to an
enum `#state`, which can be one of `"RUNNING"`, `"CLOSED"` or
`"TERMINATED"`.

The Rust side was removing the `WorkerThread` struct from the workers
table when a close control was received, regardless of whether there
were any messages left to read, which made any subsequent calls to
`op_host_recv_message` to return `Ok(None)`, as if there were no more
mesasges. This change instead waits for both a close control and for
the message channel's sender to be closed before the worker thread is
removed from the table.
2021-09-06 11:05:02 +02:00
..
examples feat(runtime): support classic workers for internal testing (#11338) 2021-08-16 14:29:54 +02:00
js Don't drop messages from workers that have already been closed (#11913) 2021-09-06 11:05:02 +02:00
ops Don't drop messages from workers that have already been closed (#11913) 2021-09-06 11:05:02 +02:00
build.rs feat(fetch): mTLS client certificates for fetch() (#11721) 2021-08-25 14:25:12 +02:00
Cargo.toml chore: update dependencies (#11856) 2021-09-02 23:38:44 +02:00
colors.rs chore: upgrade Rust to 1.54.0 (#11554) 2021-07-30 15:03:41 +02:00
errors.rs chore: update dependencies (#11856) 2021-09-02 23:38:44 +02:00
fs_util.rs fix: do not panic on not found cwd (#10238) 2021-04-21 17:52:00 +02:00
inspector_server.rs refactor: cleanup Inspector and InspectorServer implementations (#11837) 2021-08-25 13:39:23 +02:00
js.rs refactor: unify JavaScript script execution method (#11043) 2021-06-22 01:45:41 +02:00
lib.rs feat(tls): Optionally support loading native certs (#11491) 2021-08-07 14:49:38 +02:00
metrics.rs Remove various unnecessary allow(clippy) declarations (#10971) 2021-06-15 19:22:28 +02:00
permissions.rs feat: ffi to replace plugins (#11152) 2021-08-06 23:28:10 +02:00
README.md chore: fix decendents in runtime readme (#9718) 2021-03-08 13:23:46 +01:00
tokio_util.rs upgrade: tokio 1.0 (#8779) 2021-01-11 23:50:02 -08:00
web_worker.rs feat(fetch): mTLS client certificates for fetch() (#11721) 2021-08-25 14:25:12 +02:00
worker.rs feat(fetch): mTLS client certificates for fetch() (#11721) 2021-08-25 14:25:12 +02:00

deno_runtime crate

crates docs

This is a slim version of the Deno CLI which removes typescript integration and various tooling (like lint and doc). Basically only JavaScript execution with Deno's operating system bindings (ops).

Stability

This crate is built using battle-tested modules that were originally in deno crate, however the API of this crate is subject to rapid and breaking changes.

MainWorker

The main API of this crate is MainWorker. MainWorker is a structure encapsulating deno_core::JsRuntime with a set of ops used to implement Deno namespace.

When creating a MainWorker implementors must call MainWorker::bootstrap to prepare JS runtime for use.

MainWorker is highly configurable and allows to customize many of the runtime's properties:

  • module loading implementation
  • error formatting
  • support for source maps
  • support for V8 inspector and Chrome Devtools debugger
  • HTTP client user agent, CA certificate
  • random number generator seed

Worker Web API

deno_runtime comes with support for Worker Web API. The Worker API is implemented using WebWorker structure.

When creating a new instance of MainWorker implementors must provide a callback function that is used when creating a new instance of Worker.

All WebWorker instances are descendents of MainWorker which is responsible for setting up communication with child worker. Each WebWorker spawns a new OS thread that is dedicated solely to that worker.