fix(unstable/compile): handle byonm import in sub dir (#24755)

Regression in 1.45.0 caused by storing relative paths instead of
absolute paths in the binary.

Closes #24654

ext/node_resolver/resolution.rs

@@ -1370,15 +1370,37 @@ impl<TEnv: NodeResolverEnv> NodeResolver<TEnv> {
     &self,
     file_path: &Path,
   ) -> Result<Option<PackageJsonRc>, ClosestPkgJsonError> {
+    // we use this for deno compile using byonm because the script paths
+    // won't be in virtual file system, but the package.json paths will be
+    fn canonicalize_first_ancestor_exists(
+      dir_path: &Path,
+      env: &dyn NodeResolverEnv,
+    ) -> Result<Option<PathBuf>, std::io::Error> {
+      for ancestor in dir_path.ancestors() {
+        match env.realpath_sync(ancestor) {
+          Ok(dir_path) => return Ok(Some(dir_path)),
+          Err(err) if err.kind() == std::io::ErrorKind::NotFound => {
+            // keep searching
+          }
+          Err(err) => return Err(err),
+        }
+      }
+      Ok(None)
+    }
+
     let parent_dir = file_path.parent().unwrap();
-    let current_dir =
+    let Some(start_dir) = canonicalize_first_ancestor_exists(
-      strip_unc_prefix(self.env.realpath_sync(parent_dir).map_err(
+      parent_dir, &self.env,
-        |source| CanonicalizingPkgJsonDirError {
+    )
+    .map_err(|source| CanonicalizingPkgJsonDirError {
       dir_path: parent_dir.to_path_buf(),
       source,
-        },
+    })?
-      )?);
+    else {
-    for current_dir in current_dir.ancestors() {
+      return Ok(None);
+    };
+    let start_dir = strip_unc_prefix(start_dir);
+    for current_dir in start_dir.ancestors() {
       let package_json_path = current_dir.join("package.json");
       if let Some(pkg_json) = self.load_package_json(&package_json_path)? {
         return Ok(Some(pkg_json));

tests/specs/compile/byonm_main_sub_dir/__test__.jsonc

@@ -0,0 +1,28 @@
+{
+  "tempDir": true,
+  "envs": {
+    "DENO_FUTURE": "1"
+  },
+  "steps": [{
+    "args": "install",
+    "output": "[WILDCARD]"
+  }, {
+    "if": "unix",
+    "args": "compile --output main src/main.ts",
+    "output": "[WILDCARD]"
+  }, {
+    "if": "unix",
+    "commandName": "./main",
+    "args": [],
+    "output": "main.out"
+  }, {
+    "if": "windows",
+    "args": "compile --output main.exe src/main.ts",
+    "output": "[WILDCARD]"
+  }, {
+    "if": "windows",
+    "commandName": "./main.exe",
+    "args": [],
+    "output": "main.out"
+  }]
+}

tests/specs/compile/byonm_main_sub_dir/deno.json

@@ -0,0 +1,3 @@
+{
+  "unstable": ["byonm"]
+}

tests/specs/compile/byonm_main_sub_dir/main.out

@@ -0,0 +1 @@
+3

tests/specs/compile/byonm_main_sub_dir/package.json

@@ -0,0 +1,11 @@
+{
+  "name": "package",
+  "version": "1.0.0",
+  "description": "",
+  "keywords": [],
+  "author": "",
+  "license": "MIT",
+  "dependencies": {
+    "@denotest/add": "*"
+  }
+}

tests/specs/compile/byonm_main_sub_dir/src/main.ts

@@ -0,0 +1,2 @@
+import { add } from "@denotest/add";
+console.log(add(1, 2));