foster/denoland-deno
0
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-02-07 23:06:50 -05:00
Code Issues Packages 1 Wiki Activity

fix(ext/node): set process.env as own property (#27891)

Browse source 
Fixes `gcp-metadata@6.1.1`

```
% deno eval "import 'npm:gcp-metadata@6.1.1'" # main
error: Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'GOOGLE_SDK_NODE_LOGGING')
    at Object.log (file:///Users/divy/Library/Caches/deno/npm/registry.npmjs.org/google-logging-utils/0.0.2/build/src/logging-utils.js:356:36)
    at Object.<anonymous> (file:///Users/divy/Library/Caches/deno/npm/registry.npmjs.org/gcp-metadata/6.1.1/build/src/index.js:52:20)
    at Object.<anonymous> (file:///Users/divy/Library/Caches/deno/npm/registry.npmjs.org/gcp-metadata/6.1.1/build/src/index.js:409:4)
    at Module._compile (node:module:745:34)
    at loadMaybeCjs (node:module:770:10)
    at Object.Module._extensions..js (node:module:755:12)
    at Module.load (node:module:662:32)
    at Function.Module._load (node:module:534:12)
    at Module.require (node:module:681:19)
    at require (node:module:812:16)

% target/debug/deno eval "import 'npm:gcp-metadata@6.1.1'" # this PR
```

---------

Signed-off-by: Divy Srivastava <dj.srivastava23@gmail.com>
Co-authored-by: Yoshiya Hinosawa <stibium121@gmail.com>
This commit is contained in:
Divy Srivastava 2025-01-31 11:38:26 +05:30 • committed by GitHub
parent d9db0b35e0
commit 08cc22105f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
ext/node/polyfills/process.ts
View file

@ -780,6 +780,7 @@ const process = new Process();
/* Set owned property */
process.versions = versions;
process.env = env;
Object.defineProperty(process, Symbol.toStringTag, {
enumerable: false,

2
tests/unit_node/process_test.ts
View file

@ -390,6 +390,8 @@ Deno.test({
Deno.test({
name: "process.env",
fn() {
assert(Object.prototype.hasOwnProperty.call(process, "env"));
Deno.env.set("HELLO", "WORLD");
assertObjectMatch(process.env, Deno.env.toObject());