foster/denoland-deno
0
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-02-01 12:16:11 -05:00
Code Issues Packages 1 Wiki Activity

fix: Improve brotliDecompress.

Browse source 
Fixes: Uncaught (in promise) ReferenceError: callback is not defined

Test program that should then pass:

    import zlib from 'node:zlib';
    import { promisify } from 'node:util';
    import { Buffer } from 'node:buffer';
    const brotliDecompress = promisify(zlib.brotliDecompress);

    (async () => {
      const result = await brotliDecompress(Buffer.from([0x21, 0x0c, 0x00, 0x04, 0x74, 0x65, 0x73, 0x74, 0x03]));
      console.log(result.toString()); // should print "test"
    })();
This commit is contained in:
Philipp Claßen 2024-12-13 18:57:49 +01:00
parent 3946956b8c
commit 09576d7ddc
1 changed files with 12 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
ext/node/polyfills/_brotli.js
View file

@ -193,8 +193,19 @@ export function brotliCompressSync(
return Buffer.from(TypedArrayPrototypeSubarray(output, 0, len)); return Buffer.from(TypedArrayPrototypeSubarray(output, 0, len));
} }
export function brotliDecompress(input) { export function brotliDecompress(
input,
options,
callback,
) {
const buf = toU8(input); const buf = toU8(input);
if (typeof options === "function") {
callback = options;
options = {};
}
// note: `options` argument is currently not used
return PromisePrototypeCatch( return PromisePrototypeCatch(
PromisePrototypeThen( PromisePrototypeThen(
op_brotli_decompress_async(buf), op_brotli_decompress_async(buf),