foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-01-22 23:19:55 -05:00
Code Issues Packages 1 Wiki Activity

fix(std/http): verify cookie name & update SameSite type (#4685)

Browse source
This commit is contained in:
木杉 2020-04-10 22:12:42 +08:00 • committed by GitHub
parent 85c61bff1c
commit 195ad4c626
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
std/http/cookie.ts
View file

@ -22,9 +22,12 @@ export interface Cookie {
unparsed?: string[];
}
export type SameSite = "Strict" | "Lax";
export type SameSite = "Strict" | "Lax" | "None";
function toString(cookie: Cookie): string {
if (!cookie.name) {
return "";
}
const out: string[] = [];
out.push(`${cookie.name}=${cookie.value}`);
@ -115,7 +118,10 @@ export function setCookie(res: Response, cookie: Cookie): void {
// TODO (zekth) : Add proper parsing of Set-Cookie headers
// Parsing cookie headers to make consistent set-cookie header
// ref: https://tools.ietf.org/html/rfc6265#section-4.1.1
res.headers.append("Set-Cookie", toString(cookie));
const v = toString(cookie);
if (v) {
res.headers.append("Set-Cookie", v);
}
}
/**

4
std/http/cookie_test.ts
View file

@ -214,5 +214,9 @@ test({
res.headers.get("Set-Cookie"),
"cookie-1=value-1; Secure, cookie-2=value-2; Max-Age=3600"
);
res.headers = new Headers();
setCookie(res, { name: "", value: "" });
assertEquals(res.headers.get("Set-Cookie"), null);
},
});