From 2c2126918bafadca43e6b4bb8daaca40afc2ee98 Mon Sep 17 00:00:00 2001 From: Divy Srivastava Date: Mon, 4 Jul 2022 07:00:42 +0530 Subject: [PATCH] perf(serde_v8): avoid extra is_array_buffer_view check (#15056) --- serde_v8/magic/v8slice.rs | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/serde_v8/magic/v8slice.rs b/serde_v8/magic/v8slice.rs index 67255fc537..94e21b0e09 100644 --- a/serde_v8/magic/v8slice.rs +++ b/serde_v8/magic/v8slice.rs @@ -70,8 +70,7 @@ pub(crate) fn to_ranged_buffer<'s>( scope: &mut v8::HandleScope<'s>, value: v8::Local, ) -> Result<(v8::Local<'s, v8::ArrayBuffer>, Range), v8::DataError> { - if value.is_array_buffer_view() { - let view: v8::Local = value.try_into()?; + if let Ok(view) = v8::Local::::try_from(value) { let (offset, len) = (view.byte_offset(), view.byte_length()); let buffer = view.buffer(scope).ok_or(v8::DataError::NoData { expected: "view to have a buffer",