foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-01-21 21:50:00 -05:00
Code Issues Packages 1 Wiki Activity

fix(ext/node): include non-enumerable keys in Reflect.ownKeys(globalThis) (#21485)

Browse source 
Closes #21484.
This commit is contained in:
ud2 2023-12-08 00:04:44 +08:00 • committed by GitHub
parent c1fc7b2cd5
commit 3f96e5a29a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 11 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
cli/tests/testdata/npm/compare_globals/main.out vendored
View file

@ -25,3 +25,4 @@ false
false false
bar bar
bar bar
true

2
cli/tests/testdata/npm/compare_globals/main.ts vendored
View file

@ -48,3 +48,5 @@ globals.checkWindowGlobal();
(globalThis as any).foo = "bar"; (globalThis as any).foo = "bar";
console.log((globalThis as any).foo); console.log((globalThis as any).foo);
console.log(globals.getFoo()); console.log(globals.getFoo());
console.log(Reflect.ownKeys(globalThis).includes("console")); // non-enumerable keys are included

11
ext/node/global.rs
View file

@ -432,9 +432,14 @@ pub fn enumerator<'s>(
}; };
let inner = v8::Local::new(scope, inner); let inner = v8::Local::new(scope, inner);
let Some(array) = let Some(array) = inner.get_property_names(
inner.get_property_names(scope, GetPropertyNamesArgs::default()) scope,
else { GetPropertyNamesArgs {
mode: v8::KeyCollectionMode::OwnOnly,
property_filter: v8::PropertyFilter::ALL_PROPERTIES,
..Default::default()
},
) else {
return; return;
}; };