foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-01-21 04:52:26 -05:00
Code Issues Packages 1 Wiki Activity

don't allocate

Browse source
This commit is contained in:
Bartek Iwańczuk 2025-01-03 00:23:01 +01:00
parent 0db1c7965a
commit 461c5c0659
No known key found for this signature in database
GPG key ID: 0C6BCDDC3B3AD750
1 changed files with 10 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
cli/tools/lint/minified_file.rs
View file

@ -35,24 +35,23 @@ pub fn is_likely_minified(content: &str) -> bool {
return false; return false;
} }
// Preallocate a line buffer to avoid per-line allocations let mut str_ref = content;
let mut line_buffer = String::with_capacity(1024);
// Process the content character by character to avoid line allocations // Process the content character by character to avoid line allocations
let mut chars = content.chars().peekable(); let mut chars = content.chars().enumerate().peekable();
while let Some(c) = chars.next() { while let Some((idx, c)) = chars.next() {
total_chars += 1; total_chars += 1;
if c.is_whitespace() { if c.is_whitespace() {
whitespace_count += 1; whitespace_count += 1;
} }
line_buffer.push(c); str_ref = &content[..idx];
// Check for end of line or end of content // Check for end of line or end of content
if c == '\n' || chars.peek().is_none() { if c == '\n' || chars.peek().is_none() {
total_lines += 1; total_lines += 1;
let trimmed = line_buffer.trim(); let trimmed = str_ref.trim();
// Check for license/copyright only if we haven't found one yet // Check for license/copyright only if we haven't found one yet
if !has_license && !trimmed.is_empty() { if !has_license && !trimmed.is_empty() {
@ -72,25 +71,25 @@ pub fn is_likely_minified(content: &str) -> bool {
} }
if trimmed.ends_with("*/") { if trimmed.ends_with("*/") {
in_multiline_comment = false; in_multiline_comment = false;
line_buffer.clear(); str_ref = "";
continue; continue;
} }
if in_multiline_comment || trimmed.starts_with("//") { if in_multiline_comment || trimmed.starts_with("//") {
line_buffer.clear(); str_ref = "";
continue; continue;
} }
// Check line length // Check line length
if line_buffer.len() > LONG_LINE_LEN { if str_ref.len() > LONG_LINE_LEN {
long_lines_count += 1; long_lines_count += 1;
} }
line_buffer.clear(); str_ref = "";
} }
} }
// Handle case where file doesn't end with newline // Handle case where file doesn't end with newline
if !line_buffer.is_empty() { if !str_ref.is_empty() {
total_lines += 1; total_lines += 1;
} }