From 5e8209abb399850a54e5bc8ace21464eaccee8eb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bartek=20Iwa=C5=84czuk?= Date: Tue, 4 Apr 2023 16:17:36 +0200 Subject: [PATCH] refactor(ext/http): bring back 'reusePort' option for 'Deno.serve()' (#18590) Closes https://github.com/denoland/deno/issues/18582 --- cli/tests/unit/serve_test.ts | 1 + ext/http/01_http.js | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/cli/tests/unit/serve_test.ts b/cli/tests/unit/serve_test.ts index 00282d5211..32d436d04f 100644 --- a/cli/tests/unit/serve_test.ts +++ b/cli/tests/unit/serve_test.ts @@ -946,6 +946,7 @@ Deno.test( signal: ac.signal, onListen: onListen(listeningPromise), onError: createOnErrorCb(ac), + reusePort: true, }); await listeningPromise; diff --git a/ext/http/01_http.js b/ext/http/01_http.js index f434acd3c1..d0aefc0c32 100644 --- a/ext/http/01_http.js +++ b/ext/http/01_http.js @@ -657,7 +657,7 @@ async function serve(arg1, arg2) { const listenOpts = { hostname: options.hostname ?? "127.0.0.1", port: options.port ?? 9000, - reuseport: options.reusePort ?? false, + reusePort: options.reusePort ?? false, }; if (options.cert || options.key) { @@ -677,11 +677,13 @@ async function serve(arg1, arg2) { port: listenOpts.port, cert: listenOpts.cert, key: listenOpts.key, + reusePort: listenOpts.reusePort, }); } else { listener = listen({ hostname: listenOpts.hostname, port: listenOpts.port, + reusePort: listenOpts.reusePort, }); }