foster/denoland-deno
0
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-02-08 07:16:56 -05:00
Code Issues Packages 1 Wiki Activity

fix: panic with js lint plugins and invalid js syntax (#28006)

Browse source 
Noticed that the LSP might panic during serialization when working on a
file with a syntax error.

This PR changes the serialization so that invalid nodes are simply
serialized to the invalid node `0`. The plugin code treats the node with
id `0` as an invalid node and will ignore it during visiting.

I'm not sure how to write a test for the LSP.
This commit is contained in:
Marvin Hagemeister 2025-02-07 12:35:44 +01:00 • committed by GitHub
parent a82326d029
commit 703fdd8607
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 26 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

33
cli/tools/lint/ast_buffer/swc.rs
View file

@ -241,7 +241,10 @@ fn serialize_module_decl(
// Already handled earlier // Already handled earlier
ExportSpecifier::Namespace(_) => unreachable!(), ExportSpecifier::Namespace(_) => unreachable!(),
// this is not syntactically valid // this is not syntactically valid
ExportSpecifier::Default(_) => unreachable!(), ExportSpecifier::Default(_) => {
// Ignore syntax errors
NodeRef(0)
}
} }
}) })
.collect::<Vec<_>>(); .collect::<Vec<_>>();
@ -444,7 +447,10 @@ fn serialize_import_attrs(
.map(|prop| { .map(|prop| {
let (key, value) = match prop { let (key, value) = match prop {
// Invalid syntax // Invalid syntax
PropOrSpread::Spread(_) => unreachable!(), PropOrSpread::Spread(_) => {
// Ignore syntax errors
(NodeRef(0), NodeRef(0))
}
PropOrSpread::Prop(prop) => { PropOrSpread::Prop(prop) => {
match prop.as_ref() { match prop.as_ref() {
Prop::Shorthand(ident) => ( Prop::Shorthand(ident) => (
@ -459,7 +465,10 @@ fn serialize_import_attrs(
Prop::Assign(_) Prop::Assign(_)
| Prop::Getter(_) | Prop::Getter(_)
| Prop::Setter(_) | Prop::Setter(_)
| Prop::Method(_) => unreachable!(), | Prop::Method(_) => {
// Ignore syntax errors
(NodeRef(0), NodeRef(0))
}
} }
} }
}; };
@ -770,7 +779,10 @@ fn serialize_expr(ctx: &mut TsEsTreeBuilder, expr: &Expr) -> NodeRef {
SimpleAssignTarget::TsInstantiation(target) => { SimpleAssignTarget::TsInstantiation(target) => {
serialize_expr(ctx, &Expr::TsInstantiation(target.clone())) serialize_expr(ctx, &Expr::TsInstantiation(target.clone()))
} }
SimpleAssignTarget::Invalid(_) => unreachable!(), SimpleAssignTarget::Invalid(_) => {
// Ignore syntax errors
NodeRef(0)
}
} }
} }
AssignTarget::Pat(target) => match target { AssignTarget::Pat(target) => match target {
@ -780,7 +792,10 @@ fn serialize_expr(ctx: &mut TsEsTreeBuilder, expr: &Expr) -> NodeRef {
AssignTargetPat::Object(object_pat) => { AssignTargetPat::Object(object_pat) => {
serialize_pat(ctx, &Pat::Object(object_pat.clone())) serialize_pat(ctx, &Pat::Object(object_pat.clone()))
} }
AssignTargetPat::Invalid(_) => unreachable!(), AssignTargetPat::Invalid(_) => {
// Ignore syntax errors
NodeRef(0)
}
}, },
}; };
@ -1101,7 +1116,8 @@ fn serialize_expr(ctx: &mut TsEsTreeBuilder, expr: &Expr) -> NodeRef {
ctx.write_chain_expr(&node.span, expr) ctx.write_chain_expr(&node.span, expr)
} }
Expr::Invalid(_) => { Expr::Invalid(_) => {
unreachable!() // Ignore syntax errors
NodeRef(0)
} }
} }
} }
@ -1908,7 +1924,10 @@ fn serialize_pat(ctx: &mut TsEsTreeBuilder, pat: &Pat) -> NodeRef {
ctx.write_assign_pat(&node.span, left, right) ctx.write_assign_pat(&node.span, left, right)
} }
Pat::Invalid(_) => unreachable!(), Pat::Invalid(_) => {
// Ignore syntax errors
NodeRef(0)
}
Pat::Expr(node) => serialize_expr(ctx, node), Pat::Expr(node) => serialize_expr(ctx, node),
} }
} }