From 846c049c9b3ab36d0893292a204c4d0a18de4c8e Mon Sep 17 00:00:00 2001 From: Ryan Dahl Date: Wed, 6 May 2020 17:04:52 -0400 Subject: [PATCH] Remove flaky and useless tests (#5116) --- std/node/_fs/_fs_writeFile_test.ts | 18 ------------------ std/node/_fs/promises/_fs_writeFile_test.ts | 12 ------------ 2 files changed, 30 deletions(-) diff --git a/std/node/_fs/_fs_writeFile_test.ts b/std/node/_fs/_fs_writeFile_test.ts index 9b40a1fff2..427062034e 100644 --- a/std/node/_fs/_fs_writeFile_test.ts +++ b/std/node/_fs/_fs_writeFile_test.ts @@ -6,7 +6,6 @@ import { assertEquals, assertNotEquals, assertThrows, - assertThrowsAsync, } from "../../testing/asserts.ts"; import { writeFile } from "./_fs_writeFile.ts"; @@ -161,20 +160,3 @@ test("Mode is not set when rid is passed", async function testCorrectFileModeRid assert(fileInfo.mode); assertNotEquals(fileInfo.mode & 0o777, 0o777); }); - -test("Mode is not implemented on windows", function testModeNotImplementedWindows(): void { - if (Deno.build.os !== "windows") return; - - assertThrowsAsync( - () => { - return new Promise((resolve, reject) => { - writeFile("fail.txt", "some data", { mode: 0o777 }, (err) => { - if (err) return reject(err); - resolve(); - }); - }); - }, - Error, - `Not implemented: "mode" on Windows` - ); -}); diff --git a/std/node/_fs/promises/_fs_writeFile_test.ts b/std/node/_fs/promises/_fs_writeFile_test.ts index c67a7947ad..171dbeb2c3 100644 --- a/std/node/_fs/promises/_fs_writeFile_test.ts +++ b/std/node/_fs/promises/_fs_writeFile_test.ts @@ -105,15 +105,3 @@ test("Mode is not set when rid is passed", async function testCorrectFileModeRid assert(fileInfo.mode); assertNotEquals(fileInfo.mode & 0o777, 0o777); }); - -test("Mode is not implemented on windows", function testModeNotImplementedWindows(): void { - if (Deno.build.os !== "windows") return; - - assertThrowsAsync( - async () => { - await writeFile("fail.txt", "some data", { mode: 0o777 }); - }, - Error, - `Not implemented: "mode" on Windows` - ); -});