From 85b7dbc65b5d40b7ec473b671e5098ded694fb4d Mon Sep 17 00:00:00 2001 From: Luca Casonato Date: Wed, 17 Apr 2024 11:10:56 +0200 Subject: [PATCH] Revert: chore: fail properly in web platform test The previous behaviour was correct. The process exit code does not matter, because failures are expected (we are running all tests here intentionally, even failing ones). This is done so we can report both success and failure accurately to wpt.fyi. --- .github/workflows/wpt_epoch.yml | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/.github/workflows/wpt_epoch.yml b/.github/workflows/wpt_epoch.yml index 75a2886aad..c1404e6349 100644 --- a/.github/workflows/wpt_epoch.yml +++ b/.github/workflows/wpt_epoch.yml @@ -65,14 +65,17 @@ jobs: - name: Run web platform tests shell: bash + # Setup WPT and run tests. We ignore the exit code of the test run + # because the CI job reports the results to WPT.fyi, and we still want + # to report failure. run: | deno run --unstable --allow-write --allow-read --allow-net \ --allow-env --allow-run --lock=tools/deno.lock.json \ ./tests/wpt/wpt.ts setup deno run --unstable --allow-write --allow-read --allow-net \ --allow-env --allow-run --lock=tools/deno.lock.json \ - ./tests/wpt/wpt.ts run \ \ - --binary=$(which deno) --quiet --release --no-ignore --json=wpt.json --wptreport=wptreport.json + ./tests/wpt/wpt.ts run \ + --binary=$(which deno) --quiet --release --no-ignore --json=wpt.json --wptreport=wptreport.json || true - name: Upload wpt results to wpt.fyi env: