foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-01-21 21:50:00 -05:00
Code Issues Packages 1 Wiki Activity

feat(ext/console): Display error.cause in console (#12462)

Browse source
This commit is contained in:
Kenta Moriuchi 2021-10-31 02:25:46 +09:00 • committed by GitHub
parent 3fb23ab772
commit 95b9e5f30f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 63 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

42
cli/tests/unit/console_test.ts
View file

@ -1823,6 +1823,48 @@ unitTest(function inspectProxy() {
);
});
unitTest(function inspectError() {
const error1 = new Error("This is an error");
const error2 = new Error("This is an error", {
cause: new Error("This is a cause error"),
});
assertStringIncludes(
stripColor(Deno.inspect(error1)),
"Error: This is an error",
);
assertStringIncludes(
stripColor(Deno.inspect(error2)),
"Error: This is an error",
);
assertStringIncludes(
stripColor(Deno.inspect(error2)),
"Caused by Error: This is a cause error",
);
});
unitTest(function inspectErrorCircular() {
const error1 = new Error("This is an error");
const error2 = new Error("This is an error", {
cause: new Error("This is a cause error"),
});
error1.cause = error1;
error2.cause.cause = error2;
assertStringIncludes(
stripColor(Deno.inspect(error1)),
"Error: This is an error",
);
assertStringIncludes(
stripColor(Deno.inspect(error2)),
"Error: This is an error",
);
assertStringIncludes(
stripColor(Deno.inspect(error2)),
"Caused by Error: This is a cause error",
);
});
unitTest(function inspectColors() {
assertEquals(Deno.inspect(1), "1");
assertStringIncludes(Deno.inspect(1, { colors: true }), "\x1b[");

22
ext/console/02_console.js
View file

@ -883,6 +883,26 @@
return red(RegExpPrototypeToString(value)); // RegExps are red
}
function inspectError(value) {
const causes = [];
let err = value;
while (
err.cause instanceof Error && err.cause !== value &&
!ArrayPrototypeIncludes(causes, err.cause) // circular check
) {
ArrayPrototypePush(causes, err.cause);
err = err.cause;
}
return `${value.stack}${
ArrayPrototypeJoin(
ArrayPrototypeMap(causes, (cause) => `\nCaused by ${cause.stack}`),
"",
)
}`;
}
function inspectStringObject(value, inspectOptions) {
const cyan = maybeColor(colors.cyan, inspectOptions);
return cyan(`[String: "${StringPrototypeToString(value)}"]`); // wrappers are in cyan
@ -1141,7 +1161,7 @@
return String(value[privateCustomInspect](inspect));
}
if (value instanceof Error) {
return String(value.stack);
return inspectError(value);
} else if (ArrayIsArray(value)) {
return inspectArray(value, level, inspectOptions);
} else if (value instanceof Number) {