foster/denoland-deno
0
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-02-14 17:47:35 -05:00
Code Issues Packages 1 Wiki Activity

feat(ext/node): add more named curves in crypto.generateKeyPair[Sync]() (#22882)

Browse source 
Towards fixing #21761
This commit is contained in:
Asher Gomez 2024-03-13 17:44:51 +11:00 • committed by Nathan Whitaker
parent c3dbc0b38d
commit 9f8f87f27a
No known key found for this signature in database
2 changed files with 16 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
ext/node/ops/crypto/mod.rs
View file

@ -707,8 +707,12 @@ fn ec_generate(
use ring::signature::KeyPair; use ring::signature::KeyPair;
let curve = match named_curve { let curve = match named_curve {
"P-256" => &ring::signature::ECDSA_P256_SHA256_FIXED_SIGNING, "P-256" | "prime256v1" | "secp256r1" => {
"P-384" => &ring::signature::ECDSA_P384_SHA384_FIXED_SIGNING, &ring::signature::ECDSA_P256_SHA256_FIXED_SIGNING
}
"P-384" | "prime384v1" | "secp384r1" => {
&ring::signature::ECDSA_P384_SHA384_FIXED_SIGNING
}
_ => return Err(type_error("Unsupported named curve")), _ => return Err(type_error("Unsupported named curve")),
}; };

11
tests/unit_node/crypto/crypto_key_test.ts
View file

@ -106,7 +106,16 @@ for (const type of ["rsa", "rsa-pss", "dsa"]) {
} }
} }
for (const namedCurve of ["P-384", "P-256"]) { for (
const namedCurve of [
"P-384",
"prime384v1",
"secp384r1",
"P-256",
"prime256v1",
"secp256r1",
]
) {
Deno.test({ Deno.test({
name: `generate ec key ${namedCurve}`, name: `generate ec key ${namedCurve}`,
fn() { fn() {