foster/denoland-deno
0
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-02-01 12:16:11 -05:00
Code Issues Packages 1 Wiki Activity

fix(cli): deno task exit with status 0 (#25637)

Browse source 
Fixes https://github.com/denoland/deno/issues/25632

Exit code 1 indiciates some sort of failure but `deno task` (without
arguments) is used to list available commands.

---------

Co-authored-by: Yoshiya Hinosawa <stibium121@gmail.com>
This commit is contained in:
Divy Srivastava 2024-09-15 11:29:24 +05:30 • committed by GitHub
parent db6fc12b9e
commit a666c8c9f9
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
7 changed files with 10 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
cli/tools/task.rs
View file

@ -75,7 +75,7 @@ See https://docs.deno.com/go/config"#
&cli_options.start_dir, &cli_options.start_dir,
&tasks_config, &tasks_config,
)?; )?;
return Ok(1); return Ok(0);
} }
}; };

2
tests/specs/task/both_no_arg/__test__.jsonc
View file

@ -4,5 +4,5 @@
"envs": { "envs": {
"NO_COLOR": "1" "NO_COLOR": "1"
}, },
"exitCode": 1 "exitCode": 0
} }

2
tests/specs/task/cwd_resolves_config_from_specified_dir/__test__.jsonc
View file

@ -4,5 +4,5 @@
"envs": { "envs": {
"NO_COLOR": "1" "NO_COLOR": "1"
}, },
"exitCode": 1 "exitCode": 0
} }

2
tests/specs/task/doc_comments_no_args/__test__.jsonc
View file

@ -2,5 +2,5 @@
"args": "task", "args": "task",
"envs": { "NO_COLOR": "1" }, "envs": { "NO_COLOR": "1" },
"output": "task.out", "output": "task.out",
"exitCode": 1 "exitCode": 0
} }

2
tests/specs/task/no_args/__test__.jsonc
View file

@ -4,5 +4,5 @@
"envs": { "envs": {
"NO_COLOR": "1" "NO_COLOR": "1"
}, },
"exitCode": 1 "exitCode": 0
} }

2
tests/specs/task/package_json_no_arg/__test__.jsonc
View file

@ -4,5 +4,5 @@
"envs": { "envs": {
"NO_COLOR": "1" "NO_COLOR": "1"
}, },
"exitCode": 1 "exitCode": 0
} }

8
tests/specs/task/workspace/__test__.jsonc
View file

@ -3,25 +3,25 @@
"root": { "root": {
"args": "task", "args": "task",
"output": "root.out", "output": "root.out",
"exitCode": 1 "exitCode": 0
}, },
"package_a": { "package_a": {
"args": "task", "args": "task",
"cwd": "package-a", "cwd": "package-a",
"output": "package-a.out", "output": "package-a.out",
"exitCode": 1 "exitCode": 0
}, },
"package_b": { "package_b": {
"args": "task", "args": "task",
"cwd": "package-b", "cwd": "package-b",
"output": "package-b.out", "output": "package-b.out",
"exitCode": 1 "exitCode": 0
}, },
"scripts": { "scripts": {
"args": "task", "args": "task",
"cwd": "scripts", "cwd": "scripts",
"output": "scripts.out", "output": "scripts.out",
"exitCode": 1 "exitCode": 0
}, },
"package_b_tasks": { "package_b_tasks": {
"steps": [{ "steps": [{