foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-01-21 21:50:00 -05:00
Code Issues Packages 1 Wiki Activity

refactor: use Symbol.for instead of Symbol in cli/rt/ (#7537)

Browse source
This commit is contained in:
Bartek Iwańczuk 2020-09-17 18:42:36 +02:00 • committed by GitHub
parent bda9379385
commit c307e3e4be
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 22 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
cli/rt/02_console.js
View file

@ -764,6 +764,19 @@
return String(value[customInspect]());
} catch {}
}
// This non-unique symbol is used to support op_crates, ie.
// in op_crates/web we don't want to depend on unique "Deno.customInspect"
// symbol defined in the public API. Internal only, shouldn't be used
// by users.
const nonUniqueCustomInspect = Symbol.for("Deno.customInspect");
if (
nonUniqueCustomInspect in value &&
typeof value[nonUniqueCustomInspect] === "function"
) {
try {
return String(value[nonUniqueCustomInspect]());
} catch {}
}
if (value instanceof Error) {
return String(value.stack);
} else if (Array.isArray(value)) {

7
cli/rt/11_streams.js
View file

@ -11,7 +11,8 @@
const { cloneValue, setFunctionName } = window.__bootstrap.webUtil;
const { assert, AssertionError } = window.__bootstrap.util;
const { customInspect, inspect } = window.__bootstrap.console;
const customInspect = Symbol.for("Deno.customInspect");
const sym = {
abortAlgorithm: Symbol("abortAlgorithm"),
@ -636,9 +637,7 @@
}
[customInspect]() {
return `${this.constructor.name} {\n readable: ${
inspect(this.readable)
}\n writable: ${inspect(this.writable)}\n}`;
return this.constructor.name;
}
}

3
cli/rt/11_url.js
View file

@ -2,7 +2,6 @@
((window) => {
const core = window.Deno.core;
const { customInspect } = window.__bootstrap.console;
const { isIterable, requiredArguments } = window.__bootstrap.webUtil;
/** https://url.spec.whatwg.org/#idna */
@ -492,7 +491,7 @@
class URL {
#searchParams = null;
[customInspect]() {
[Symbol.for("Deno.customInspect")]() {
const keys = [
"href",
"origin",

3
cli/rt/20_headers.js
View file

@ -3,7 +3,6 @@
((window) => {
const { DomIterableMixin } = window.__bootstrap.domIterable;
const { requiredArguments } = window.__bootstrap.webUtil;
const { customInspect } = window.__bootstrap.console;
// From node-fetch
// Copyright (c) 2016 David Frank. MIT License.
@ -194,7 +193,7 @@
}
}
[customInspect]() {
[Symbol.for("Deno.customInspect")]() {
let length = this[headersData].length;
let output = "";
for (const [key, value] of this[headersData]) {

2
cli/rt/20_streams_queuing_strategy.js
View file

@ -1,7 +1,7 @@
// Copyright 2018-2020 the Deno authors. All rights reserved. MIT license.
((window) => {
const { customInspect } = window.__bootstrap.console;
const customInspect = Symbol.for("Deno.customInspect");
class CountQueuingStrategy {
constructor({ highWaterMark }) {

6
cli/rt/40_performance.js
View file

@ -2,9 +2,9 @@
((window) => {
const { opNow } = window.__bootstrap.timers;
const { customInspect, inspect } = window.__bootstrap.console;
const { cloneValue } = window.__bootstrap.webUtil;
const customInspect = Symbol.for("Deno.customInspect");
let performanceEntries = [];
function findMostRecent(
@ -130,7 +130,7 @@
[customInspect]() {
return this.detail
? `${this.constructor.name} {\n detail: ${
inspect(this.detail, { depth: 3 })
JSON.stringify(this.detail, null, 2)
},\n name: "${this.name}",\n entryType: "${this.entryType}",\n startTime: ${this.startTime},\n duration: ${this.duration}\n}`
: `${this.constructor.name} { detail: ${this.detail}, name: "${this.name}", entryType: "${this.entryType}", startTime: ${this.startTime}, duration: ${this.duration} }`;
}
@ -170,7 +170,7 @@
[customInspect]() {
return this.detail
? `${this.constructor.name} {\n detail: ${
inspect(this.detail, { depth: 3 })
JSON.stringify(this.detail, null, 2)
},\n name: "${this.name}",\n entryType: "${this.entryType}",\n startTime: ${this.startTime},\n duration: ${this.duration}\n}`
: `${this.constructor.name} { detail: ${this.detail}, name: "${this.name}", entryType: "${this.entryType}", startTime: ${this.startTime}, duration: ${this.duration} }`;
}