foster/denoland-deno
0
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-02-01 12:16:11 -05:00
Code Issues Packages 1 Wiki Activity

fix: do not return undefined for missing global properties (#24474)

Browse source 
accessing e.g. `Buffer` in `Mode::Deno` mode should throw, not return
undefined.

---------

Signed-off-by: snek <snek@deno.com>
This commit is contained in:
snek 2024-07-09 10:07:56 -07:00 • committed by GitHub
parent 839caf6faf
commit c461f8fd2e
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 20 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
ext/node/global.rs
View file

@ -305,6 +305,10 @@ pub fn getter<'s>(
let reflect_get = v8::Local::new(scope, reflect_get); let reflect_get = v8::Local::new(scope, reflect_get);
let inner = v8::Local::new(scope, inner); let inner = v8::Local::new(scope, inner);
if !inner.has_own_property(scope, key).unwrap_or(false) {
return v8::Intercepted::No;
}
let undefined = v8::undefined(scope); let undefined = v8::undefined(scope);
let Some(value) = reflect_get.call( let Some(value) = reflect_get.call(
scope, scope,

6
ext/web/02_timers.js
View file

@ -35,7 +35,7 @@ function checkThis(thisArg) {
function setImmediate(callback, ...args) { function setImmediate(callback, ...args) {
if (args.length > 0) { if (args.length > 0) {
const unboundCallback = callback; const unboundCallback = callback;
callback = () => ReflectApply(unboundCallback, window, args); callback = () => ReflectApply(unboundCallback, globalThis, args);
} }
return core.queueImmediate( return core.queueImmediate(
@ -55,7 +55,7 @@ function setTimeout(callback, timeout = 0, ...args) {
} }
if (args.length > 0) { if (args.length > 0) {
const unboundCallback = callback; const unboundCallback = callback;
callback = () => ReflectApply(unboundCallback, window, args); callback = () => ReflectApply(unboundCallback, globalThis, args);
} }
timeout = webidl.converters.long(timeout); timeout = webidl.converters.long(timeout);
return core.queueUserTimer( return core.queueUserTimer(
@ -77,7 +77,7 @@ function setInterval(callback, timeout = 0, ...args) {
} }
if (args.length > 0) { if (args.length > 0) {
const unboundCallback = callback; const unboundCallback = callback;
callback = () => ReflectApply(unboundCallback, window, args); callback = () => ReflectApply(unboundCallback, globalThis, args);
} }
timeout = webidl.converters.long(timeout); timeout = webidl.converters.long(timeout);
return core.queueUserTimer( return core.queueUserTimer(

1
tests/node_compat/test/common/index.js
View file

@ -62,7 +62,6 @@ let knownGlobals = [
self, self,
sessionStorage, sessionStorage,
setImmediate, setImmediate,
window,
]; ];
if (global.AbortController) if (global.AbortController)

14
tests/unit/globals_test.ts
View file

@ -1,7 +1,12 @@
// Copyright 2018-2024 the Deno authors. All rights reserved. MIT license. // Copyright 2018-2024 the Deno authors. All rights reserved. MIT license.
// deno-lint-ignore-file no-window-prefix no-window // deno-lint-ignore-file no-window-prefix no-window
import { assert, assertEquals, assertRejects } from "./test_util.ts"; import {
assert,
assertEquals,
assertRejects,
assertThrows,
} from "./test_util.ts";
Deno.test(function globalThisExists() { Deno.test(function globalThisExists() {
assert(globalThis != null); assert(globalThis != null);
@ -224,3 +229,10 @@ Deno.test(function mapGroupBy() {
quantity: 5, quantity: 5,
}]); }]);
}); });
Deno.test(function nodeGlobalsRaise() {
assertThrows(() => {
// @ts-ignore yes that's the point
Buffer;
}, ReferenceError);
});