foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-01-21 21:50:00 -05:00
Code Issues Packages 1 Wiki Activity

feat: Deno namespace configurable and unfrozen (#11062)

Browse source 
Closes #11033
This commit is contained in:
Kitson Kelly 2021-06-22 07:17:35 +10:00 • committed by GitHub
parent 2d2b5625e0
commit cda15f2a98
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 16 additions and 45 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

50
cli/tests/unit/globals_test.ts
View file

@ -62,8 +62,8 @@ unitTest(function DenoNamespaceEqualsWindowDeno(): void {
assert(Deno === window.Deno);
});
unitTest(function DenoNamespaceIsFrozen(): void {
assert(Object.isFrozen(Deno));
unitTest(function DenoNamespaceIsNotFrozen(): void {
assert(!Object.isFrozen(Deno));
});
unitTest(function webAssemblyExists(): void {
@ -77,46 +77,14 @@ declare global {
}
}
unitTest(function DenoNamespaceImmutable(): void {
const denoCopy = window.Deno;
try {
// deno-lint-ignore no-explicit-any
(Deno as any) = 1;
} catch {
// pass
}
assert(denoCopy === Deno);
try {
// deno-lint-ignore no-explicit-any
(window as any).Deno = 1;
} catch {
// pass
}
assert(denoCopy === Deno);
try {
// deno-lint-ignore no-explicit-any
delete (window as any).Deno;
} catch {
// pass
}
assert(denoCopy === Deno);
const { readFile } = Deno;
try {
// deno-lint-ignore no-explicit-any
(Deno as any).readFile = 1;
} catch {
// pass
}
assert(readFile === Deno.readFile);
try {
// deno-lint-ignore no-explicit-any
delete (window as any).Deno.readFile;
} catch {
// pass
}
assert(readFile === Deno.readFile);
unitTest(function DenoNamespaceConfigurable() {
const desc = Object.getOwnPropertyDescriptor(globalThis, "Deno");
assert(desc);
assert(desc.configurable);
assert(!desc.writable);
});
unitTest(function DenoCoreNamespaceIsImmutable(): void {
const { print } = Deno.core;
try {
Deno.core.print = 1;

4
runtime/js/06_util.js
View file

@ -117,6 +117,7 @@
return {
value,
writable: true,
enumerable: false,
configurable: true,
};
}
@ -125,6 +126,8 @@
return {
value,
enumerable: true,
writable: false,
configurable: true,
};
}
@ -132,6 +135,7 @@
return {
get: getter,
enumerable: true,
configurable: true,
};
}

7
runtime/js/99_main.js
View file

@ -492,10 +492,9 @@ delete Object.prototype.__proto__;
Object.assign(finalDenoNs, denoNsUnstable);
}
// Setup `Deno` global - we're actually overriding already
// existing global `Deno` with `Deno` namespace from "./deno.ts".
util.immutableDefine(globalThis, "Deno", finalDenoNs);
Object.freeze(globalThis.Deno);
// Setup `Deno` global - we're actually overriding already existing global
// `Deno` with `Deno` namespace from "./deno.ts".
Object.defineProperty(globalThis, "Deno", util.readOnly(finalDenoNs));
Object.freeze(globalThis.Deno.core);
Object.freeze(globalThis.Deno.core.sharedQueue);
signals.setSignals();