From d72e0281ff41a87c32aefd0876bace23470a4dc5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bartek=20Iwa=C5=84czuk?= Date: Fri, 26 May 2023 16:17:12 +0200 Subject: [PATCH] chore: upgrade rusty_v8 to 0.73.0 (#19278) --- Cargo.lock | 4 ++-- Cargo.toml | 2 +- cli/napi/js_native_api.rs | 11 +++++++---- core/ops_builtin_v8.rs | 12 ++++++------ 4 files changed, 16 insertions(+), 13 deletions(-) diff --git a/Cargo.lock b/Cargo.lock index 55706b8bbb..bafae59321 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -5711,9 +5711,9 @@ dependencies = [ [[package]] name = "v8" -version = "0.72.0" +version = "0.73.0" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "d5c1d09f66ab7f69e36211c5488d47f683fef6b65b83a627cfd75ed9cef254e6" +checksum = "e1bd3f04ba5065795dae6e3db668ff0b628920fbd2e39c1755e9b62d93660c3c" dependencies = [ "bitflags 1.3.2", "fslock", diff --git a/Cargo.toml b/Cargo.toml index f7cbae3677..78a3362bf6 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -41,7 +41,7 @@ license = "MIT" repository = "https://github.com/denoland/deno" [workspace.dependencies] -v8 = { version = "0.72.0", default-features = false } +v8 = { version = "0.73.0", default-features = false } deno_ast = { version = "0.26.0", features = ["transpiling"] } deno_core = { version = "0.188.0", path = "./core" } diff --git a/cli/napi/js_native_api.rs b/cli/napi/js_native_api.rs index ed8aacb477..900a50f403 100644 --- a/cli/napi/js_native_api.rs +++ b/cli/napi/js_native_api.rs @@ -1444,18 +1444,21 @@ fn napi_define_class( None }; - let mut accessor_property = v8::NONE; + let mut accessor_property = v8::PropertyAttribute::NONE; if getter.is_some() && setter.is_some() && (p.attributes & napi_writable) == 0 { - accessor_property = accessor_property | v8::READ_ONLY; + accessor_property = + accessor_property | v8::PropertyAttribute::READ_ONLY; } if p.attributes & napi_enumerable == 0 { - accessor_property = accessor_property | v8::DONT_ENUM; + accessor_property = + accessor_property | v8::PropertyAttribute::DONT_ENUM; } if p.attributes & napi_configurable == 0 { - accessor_property = accessor_property | v8::DONT_DELETE; + accessor_property = + accessor_property | v8::PropertyAttribute::DONT_DELETE; } let proto = tpl.prototype_template(scope); diff --git a/core/ops_builtin_v8.rs b/core/ops_builtin_v8.rs index 8da4842258..8987a56b6a 100644 --- a/core/ops_builtin_v8.rs +++ b/core/ops_builtin_v8.rs @@ -625,21 +625,21 @@ fn op_get_non_index_property_names<'a>( Err(_) => return None, }; - let mut property_filter = v8::ALL_PROPERTIES; + let mut property_filter = v8::PropertyFilter::ALL_PROPERTIES; if filter & 1 == 1 { - property_filter = property_filter | v8::ONLY_WRITABLE + property_filter = property_filter | v8::PropertyFilter::ONLY_WRITABLE } if filter & 2 == 2 { - property_filter = property_filter | v8::ONLY_ENUMERABLE + property_filter = property_filter | v8::PropertyFilter::ONLY_ENUMERABLE } if filter & 4 == 4 { - property_filter = property_filter | v8::ONLY_CONFIGURABLE + property_filter = property_filter | v8::PropertyFilter::ONLY_CONFIGURABLE } if filter & 8 == 8 { - property_filter = property_filter | v8::SKIP_STRINGS + property_filter = property_filter | v8::PropertyFilter::SKIP_STRINGS } if filter & 16 == 16 { - property_filter = property_filter | v8::SKIP_SYMBOLS + property_filter = property_filter | v8::PropertyFilter::SKIP_SYMBOLS } let maybe_names = obj.get_property_names(