foster/denoland-deno
0
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-02-01 20:25:12 -05:00
Code Issues Packages 1 Wiki Activity

fix(node/http): export globalAgent (#21081)

Browse source 
Fixes #21080 
Fixes #18312

---------

Signed-off-by: Jacob Hummer <jcbhmr@outlook.com>
This commit is contained in:
Jacob Hummer 2023-11-10 22:43:30 -06:00 • committed by Yoshiya Hinosawa
parent 407230fec3
commit f155ca7a62
No known key found for this signature in database
GPG key ID: 9017DB4559488785
3 changed files with 27 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
cli/tests/unit_node/http_test.ts
View file

@ -812,3 +812,27 @@ Deno.test(
await server.finished;
},
);
Deno.test("[node/http] node:http exports globalAgent", async () => {
const http = await import("node:http");
assert(
http.globalAgent,
"node:http must export 'globalAgent' on module namespace",
);
assert(
http.default.globalAgent,
"node:http must export 'globalAgent' on module default export",
);
});
Deno.test("[node/https] node:https exports globalAgent", async () => {
const https = await import("node:https");
assert(
https.globalAgent,
"node:https must export 'globalAgent' on module namespace",
);
assert(
https.default.globalAgent,
"node:https must export 'globalAgent' on module default export",
);
});

2
ext/node/polyfills/http.ts
View file

@ -1764,6 +1764,7 @@ export function get(...args: any[]) {
export {
Agent,
ClientRequest,
globalAgent,
IncomingMessageForServer as IncomingMessage,
METHODS,
OutgoingMessage,
@ -1771,6 +1772,7 @@ export {
};
export default {
Agent,
globalAgent,
ClientRequest,
STATUS_CODES,
METHODS,

2
ext/node/polyfills/https.ts
View file

@ -104,7 +104,7 @@ export class Agent extends HttpAgent {
}
}
const globalAgent = new Agent({
export const globalAgent = new Agent({
keepAlive: true,
scheduling: "lifo",
timeout: 5000,