From f5d749d922e6434b876ac322ce0c1aeb9af1078c Mon Sep 17 00:00:00 2001 From: Luca Casonato Date: Sun, 9 Jun 2024 02:03:07 +0200 Subject: [PATCH] fix(ext/http): print `[]` around ipv6 addresses (#24150) --- ext/http/00_serve.ts | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/ext/http/00_serve.ts b/ext/http/00_serve.ts index 1f83ce73d1..7c665ac154 100644 --- a/ext/http/00_serve.ts +++ b/ext/http/00_serve.ts @@ -34,6 +34,7 @@ const { ObjectPrototypeIsPrototypeOf, PromisePrototypeCatch, PromisePrototypeThen, + StringPrototypeIncludes, Symbol, TypeError, TypedArrayPrototypeGetSymbolToStringTag, @@ -656,14 +657,19 @@ function serve(arg1, arg2) { // If the hostname is "0.0.0.0", we display "localhost" in console // because browsers in Windows don't resolve "0.0.0.0". // See the discussion in https://github.com/denoland/deno_std/issues/1165 - const hostname = addr.hostname == "0.0.0.0" ? "localhost" : addr.hostname; + const hostname = addr.hostname == "0.0.0.0" || addr.hostname == "::" + ? "localhost" + : addr.hostname; addr.hostname = hostname; const onListen = (scheme) => { if (options.onListen) { options.onListen(addr); } else { - console.log(`Listening on ${scheme}${addr.hostname}:${addr.port}/`); + const host = StringPrototypeIncludes(addr.hostname, ":") + ? `[${addr.hostname}]` + : addr.hostname; + console.log(`Listening on ${scheme}${host}:${addr.port}/`); } };