mirror of
https://github.com/denoland/deno.git
synced 2025-02-20 20:33:42 -05:00
0e47205ebe
This PR resolves 2 issues of Socket class of node compat (both are related to playwright) Currently `browser.launch()` of playwright is not working. `browser.launch` opens PipeTransport (which is based on Pipe/IPC socket) with the browser process. But that pipe doesn't start reading the data because of the workaround #27662 (which pauses the socket at the beginning if it's from playwright-core). This PR fixes this issue by checking whether the given handle is `ipc` handle or not. Another issue is that sock-init-workaround for TLS connection stopped working at #27707 because of the changes of TLS socket initialization steps. This change fixes the issue by correctly returning the function in workaround path. The added case `specs::npm::playwright_compat` checks both fixes with actual playwright and playwright-core packages. `browser.launch` issues closes #16899 closes #27623 `https.request` issue closes #27658
16 lines
477 B
JSON
16 lines
477 B
JSON
{
|
|
"envs": {
|
|
"PLAYWRIGHT_BROWSERS_PATH": "../../../../.ms-playwright"
|
|
},
|
|
"steps": [{
|
|
"args": "run -A npm:playwright install chromium",
|
|
"output": "[WILDCARD]"
|
|
}, {
|
|
// stdio pipes beyond stdin/stdout/stderr are not currently supported on windows
|
|
// https://github.com/denoland/deno/issues/23524
|
|
// TODO(kt3k): enable this on windows when the issue is fixed
|
|
"if": "unix",
|
|
"args": "run -A main.ts",
|
|
"output": "chromium launched\n"
|
|
}]
|
|
}
|