denoland-deno/tests/specs/npm/playwright_compat/main.ts at 08cc22105f092f556f463e9245a3427d319d4b13 - foster/denoland-deno - Foster's Laboratory

foster/denoland-deno

mirror of https://github.com/denoland/deno.git synced 2025-02-21 04:42:51 -05:00

Yoshiya Hinosawa 0e47205ebe

fix(ext/node): do not apply socket-init-workaround to ipc socket (#27779 )

This PR resolves 2 issues of Socket class of node compat (both are
related to playwright)

Currently `browser.launch()` of playwright is not working.
`browser.launch` opens PipeTransport (which is based on Pipe/IPC socket)
with the browser process. But that pipe doesn't start reading the data
because of the workaround #27662 (which pauses the socket at the
beginning if it's from playwright-core). This PR fixes this issue by
checking whether the given handle is `ipc` handle or not.

Another issue is that sock-init-workaround for TLS connection stopped
working at #27707 because of the changes of TLS socket initialization
steps. This change fixes the issue by correctly returning the function
in workaround path.

The added case `specs::npm::playwright_compat` checks both fixes with
actual playwright and playwright-core packages.

`browser.launch` issues
closes #16899
closes #27623 

`https.request` issue
closes #27658

2025-01-28 15:38:45 +09:00

4 lines

116 B

TypeScript

Raw Blame History

 import { chromium } from "npm:playwright";
 await chromium.launch();
 console.log("chromium launched");
 Deno.exit(0);