denoland-deno/tests/specs/npm/npm_check_updates/output.out at 1baa33f1ee0c4ab27369f8b23cba3614a8f78a9e - foster/denoland-deno - Foster's Laboratory

foster/denoland-deno

mirror of https://github.com/denoland/deno.git synced 2025-02-21 12:53:05 -05:00

Yoshiya Hinosawa 25e0a2e567

fix(ext/node): apply @npmcli/agent workaround to npm-check-updates (#27639 )

See the comment
https://github.com/denoland/deno/pull/25470#issuecomment-2435077722 for
the reason why we do this workaround to make `make-fetch-happen` work in
Deno

This PR applies the same workaround to `npm-check-updates` package.
`npm-check-updates` internally uses
[`npm-registry-fetch`](https://www.npmjs.com/package/npm-registry-fetch)
which uses
[`make-fetch-happen`](https://www.npmjs.com/package/make-fetch-happen)
(the problematic package) for making http request to npm registry.

The detection of `make-fetch-happen` doesn't work for
`npm-check-updates` because we use call stack at `net.Socket`
constructor to check if it's called from `make-fetch-happen`, but
`npm-check-updates` bundles its dependency and the check doesn't work.

This PR adds the check of `npm-check-updates` string in call stack in
net.Socket constructor to trigger the workaroud.

closes #27629

2025-01-16 23:32:09 +01:00

2 lines

No EOL

71 B

Text

Raw Blame History

	`[WILDCARD]`
	`All dependencies match the latest package versions[WILDCARD]`