0
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-02-01 20:25:12 -05:00
denoland-deno/tests/specs/check/import_meta_no_errors
Nathan Whitaker 464ee9155e
fix(check/lsp): fix bugs with tsc type resolution, allow npm packages to augment ImportMeta (#27690)
Fixes #26224.
Fixes #27042.

There were three bugs here:
- we were only resolving `/// <reference types` directives starting with
`npm:`, which meant we failed to resolve bare specifiers (this broke the
`/// <reference types="vite/client">` directive in most of the vite
templates)
- the `$node_modules` workaround caused us to fail to read files for
tsc. For instance tsc would construct new paths based on specifiers
containing `$node_modules`, and since we hadn't created those we weren't
mapping them back to the original (this broke some type resolution
within `vite/client`)
- our separation of `ImportMeta` across node and deno globals in tsc
meant that npm packages couldn't augment `ImportMeta` (this broke
`vite/client`'s augmentation to add `import.meta.env` and others)


After this, the only remaining issue in the vanilla vite template is our
error on `/vite.svg` (which is an ambient module), and I'll look into
that next.
2025-01-16 19:20:04 +00:00
..
__test__.jsonc fix(check/lsp): fix bugs with tsc type resolution, allow npm packages to augment ImportMeta (#27690) 2025-01-16 19:20:04 +00:00
deno.json fix(check/lsp): fix bugs with tsc type resolution, allow npm packages to augment ImportMeta (#27690) 2025-01-16 19:20:04 +00:00
main.ts fix(check/lsp): fix bugs with tsc type resolution, allow npm packages to augment ImportMeta (#27690) 2025-01-16 19:20:04 +00:00
set_node_modules_dir.ts fix(check/lsp): fix bugs with tsc type resolution, allow npm packages to augment ImportMeta (#27690) 2025-01-16 19:20:04 +00:00