0
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-02-08 07:16:56 -05:00
denoland-deno/.github
Yoshiya Hinosawa 0e47205ebe
fix(ext/node): do not apply socket-init-workaround to ipc socket (#27779)
This PR resolves 2 issues of Socket class of node compat (both are
related to playwright)

Currently `browser.launch()` of playwright is not working.
`browser.launch` opens PipeTransport (which is based on Pipe/IPC socket)
with the browser process. But that pipe doesn't start reading the data
because of the workaround #27662 (which pauses the socket at the
beginning if it's from playwright-core). This PR fixes this issue by
checking whether the given handle is `ipc` handle or not.

Another issue is that sock-init-workaround for TLS connection stopped
working at #27707 because of the changes of TLS socket initialization
steps. This change fixes the issue by correctly returning the function
in workaround path.

The added case `specs::npm::playwright_compat` checks both fixes with
actual playwright and playwright-core packages.

`browser.launch` issues
closes #16899
closes #27623 

`https.request` issue
closes #27658
2025-01-28 15:38:45 +09:00
..
ISSUE_TEMPLATE fix(fmt): upgrade to dprint-plugin-markdown 0.17.4 (#25075) 2024-08-17 12:51:36 +02:00
mtime_cache chore: Happy New Year 2025 (#27509) 2024-12-31 19:12:39 +00:00
workflows fix(ext/node): do not apply socket-init-workaround to ipc socket (#27779) 2025-01-28 15:38:45 +09:00
CODE_OF_CONDUCT.md Update code-of-conduct email (#18162) 2023-03-13 17:14:06 +00:00
PULL_REQUEST_TEMPLATE.md chore: Update PR template (#22340) 2024-02-07 19:54:08 -07:00
SECURITY.md chore: update SECURITY.md (#21766) 2024-01-02 17:53:01 -05:00