foster/denoland-rusty-v8
0
0
Fork 0
mirror of https://github.com/denoland/rusty_v8.git synced 2025-01-22 06:09:47 -05:00
Code Issues Activity

Strengthen fast call API test (#1093)

Browse source 
Check that it actually performs the expected operation (adding two
numbers) because it didn't - the callback's function prototype was
wrong. V8 always passes the receiver object as the first parameter.
This commit is contained in:
Ben Noordhuis 2022-10-09 15:26:06 +02:00 • committed by GitHub
parent b2a09e2f14
commit 213305b3de
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 12 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
tests/test_api.rs
View file

@ -7595,7 +7595,7 @@ fn host_create_shadow_realm_context_callback() {
#[test] #[test]
fn test_fast_calls() { fn test_fast_calls() {
static mut WHO: &str = "none"; static mut WHO: &str = "none";
fn fast_fn(a: u32, b: u32) -> u32 { fn fast_fn(_recv: v8::Local<v8::Object>, a: u32, b: u32) -> u32 {
unsafe { WHO = "fast" }; unsafe { WHO = "fast" };
a + b a + b
} }
@ -7603,7 +7603,8 @@ fn test_fast_calls() {
pub struct FastTest; pub struct FastTest;
impl fast_api::FastFunction for FastTest { impl fast_api::FastFunction for FastTest {
fn args(&self) -> &'static [fast_api::Type] { fn args(&self) -> &'static [fast_api::Type] {
&[fast_api::Type::Uint32, fast_api::Type::Uint32] use fast_api::Type::*;
&[V8Value, Uint32, Uint32]
} }
fn return_type(&self) -> fast_api::CType { fn return_type(&self) -> fast_api::CType {
@ -7617,11 +7618,13 @@ fn test_fast_calls() {
fn slow_fn( fn slow_fn(
scope: &mut v8::HandleScope, scope: &mut v8::HandleScope,
_: v8::FunctionCallbackArguments, args: v8::FunctionCallbackArguments,
mut rv: v8::ReturnValue, mut rv: v8::ReturnValue,
) { ) {
unsafe { WHO = "slow" }; unsafe { WHO = "slow" };
rv.set(v8::Boolean::new(scope, false).into()); let a = args.get(0).uint32_value(scope).unwrap();
let b = args.get(1).uint32_value(scope).unwrap();
rv.set_uint32(a + b);
} }
let _setup_guard = setup(); let _setup_guard = setup();
@ -7639,16 +7642,16 @@ fn test_fast_calls() {
let value = template.get_function(scope).unwrap(); let value = template.get_function(scope).unwrap();
global.set(scope, name.into(), value.into()).unwrap(); global.set(scope, name.into(), value.into()).unwrap();
let source = r#" let source = r#"
function f(x, y) { return func(x, y); } function f(x, y) { return func(x, y); }
%PrepareFunctionForOptimization(f); %PrepareFunctionForOptimization(f);
f(1, 2); if (42 !== f(19, 23)) throw "unexpected";
"#; "#;
eval(scope, source).unwrap(); eval(scope, source).unwrap();
assert_eq!("slow", unsafe { WHO }); assert_eq!("slow", unsafe { WHO });
let source = r#" let source = r#"
%OptimizeFunctionOnNextCall(f); %OptimizeFunctionOnNextCall(f);
f(1, 2); if (42 !== f(19, 23)) throw "unexpected";
"#; "#;
eval(scope, source).unwrap(); eval(scope, source).unwrap();
assert_eq!("fast", unsafe { WHO }); assert_eq!("fast", unsafe { WHO });